Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 2407343002: cocoa browser: fix meaning of "continuous pulsing" (Closed)

Created:
4 years, 2 months ago by Elly Fong-Jones
Modified:
4 years, 2 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cocoa browser: fix meaning of "continuous pulsing" This state has long meant "continuously drawn as pulsed on", but still does constant repaints as though it was actually animating to a different state. This change causes continuous pulsing not to be marked as a dynamic state and updates the comment to match. BUG=650115 Committed: https://crrev.com/381689d5e039af3fb7e97571928ab7c7905b7f7c Cr-Commit-Position: refs/heads/master@{#424740}

Patch Set 1 #

Patch Set 2 : setIsContinuousPulsing -> setPulseIsStuckOn #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -66 lines) Patch
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller_unittest.mm View 1 2 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_button.h View 1 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_button.mm View 1 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/gradient_button_cell.h View 1 3 chunks +7 lines, -9 lines 0 comments Download
M chrome/browser/ui/cocoa/gradient_button_cell.mm View 1 9 chunks +13 lines, -27 lines 0 comments Download
M chrome/browser/ui/cocoa/gradient_button_cell_unittest.mm View 1 1 chunk +8 lines, -9 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Elly Fong-Jones
avi: ptal? :) this is a little... expedient but it works
4 years, 2 months ago (2016-10-11 16:35:59 UTC) #3
Avi (use Gerrit)
On 2016/10/11 16:35:59, Elly Fong-Jones wrote: > avi: ptal? :) this is a little... expedient ...
4 years, 2 months ago (2016-10-11 17:06:50 UTC) #4
Elly Fong-Jones
On 2016/10/11 17:06:50, Avi wrote: > On 2016/10/11 16:35:59, Elly Fong-Jones wrote: > > avi: ...
4 years, 2 months ago (2016-10-12 12:55:22 UTC) #5
Avi (use Gerrit)
Thank you. LGTM
4 years, 2 months ago (2016-10-12 15:06:09 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2407343002/20001
4 years, 2 months ago (2016-10-12 15:06:48 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-12 15:23:58 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-12 15:27:03 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/381689d5e039af3fb7e97571928ab7c7905b7f7c
Cr-Commit-Position: refs/heads/master@{#424740}

Powered by Google App Engine
This is Rietveld 408576698