Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(755)

Unified Diff: chrome/browser/ui/cocoa/gradient_button_cell_unittest.mm

Issue 2407343002: cocoa browser: fix meaning of "continuous pulsing" (Closed)
Patch Set: setIsContinuousPulsing -> setPulseIsStuckOn Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/cocoa/gradient_button_cell.mm ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/gradient_button_cell_unittest.mm
diff --git a/chrome/browser/ui/cocoa/gradient_button_cell_unittest.mm b/chrome/browser/ui/cocoa/gradient_button_cell_unittest.mm
index 7064ff3ba64e1402e88211a4f1c7ca325d0635aa..f5a296f14b91129cebc6e0ee7036143c827788b5 100644
--- a/chrome/browser/ui/cocoa/gradient_button_cell_unittest.mm
+++ b/chrome/browser/ui/cocoa/gradient_button_cell_unittest.mm
@@ -83,17 +83,16 @@ - (void)performOnePulseStep;
GradientButtonCell* cell = [view_ cell];
// On/off
- EXPECT_FALSE([cell isContinuousPulsing]);
- [cell setIsContinuousPulsing:YES];
- EXPECT_TRUE([cell isContinuousPulsing]);
- EXPECT_TRUE([cell pulsing]);
- [cell setIsContinuousPulsing:NO];
- EXPECT_FALSE([cell isContinuousPulsing]);
+ EXPECT_FALSE([cell isPulseStuckOn]);
+ [cell setPulseIsStuckOn:YES];
+ EXPECT_TRUE([cell isPulseStuckOn]);
+ EXPECT_FALSE([cell pulsing]);
+ [cell setPulseIsStuckOn:NO];
+ EXPECT_FALSE([cell isPulseStuckOn]);
// On/safeOff
- [cell setIsContinuousPulsing:YES];
- EXPECT_TRUE([cell isContinuousPulsing]);
- [cell safelyStopPulsing];
+ [cell setPulseIsStuckOn:YES];
+ EXPECT_TRUE([cell isPulseStuckOn]);
}
// More for valgrind; we don't confirm state change does anything useful.
« no previous file with comments | « chrome/browser/ui/cocoa/gradient_button_cell.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698