Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2035)

Unified Diff: chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm

Issue 2407343002: cocoa browser: fix meaning of "continuous pulsing" (Closed)
Patch Set: setIsContinuousPulsing -> setPulseIsStuckOn Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller_unittest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm
diff --git a/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm b/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm
index 0b6932737fef892615a3a9eb78334d5c72fd6992..a38b2a660729d81749d63ae72f435946c135349a 100644
--- a/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm
+++ b/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm
@@ -343,7 +343,7 @@ - (BookmarkButton*)bookmarkButtonToPulseForNode:(const BookmarkNode*)node {
if (node->parent() == bookmarkModel_->bookmark_bar_node()) {
for (BookmarkButton* button in [self buttons]) {
if ([button bookmarkNode] == node) {
- [button setIsContinuousPulsing:YES];
+ [button setPulseIsStuckOn:YES];
return button;
}
}
@@ -362,7 +362,7 @@ - (void)startPulsingBookmarkNode:(const BookmarkNode*)node {
if (!pulsingButton_)
return;
- [pulsingButton_ setIsContinuousPulsing:YES];
+ [pulsingButton_ setPulseIsStuckOn:YES];
pulsingBookmarkObserver_.reset(
new BookmarkModelObserverForCocoa(bookmarkModel_, ^() {
// Stop pulsing if anything happened to the node.
@@ -375,7 +375,7 @@ - (void)stopPulsingBookmarkNode {
if (!pulsingButton_)
return;
- [pulsingButton_ setIsContinuousPulsing:NO];
+ [pulsingButton_ setPulseIsStuckOn:NO];
pulsingButton_ = nil;
pulsingBookmarkObserver_.reset();
}
« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller_unittest.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698