Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Unified Diff: chrome/browser/ui/cocoa/gradient_button_cell.h

Issue 2407343002: cocoa browser: fix meaning of "continuous pulsing" (Closed)
Patch Set: setIsContinuousPulsing -> setPulseIsStuckOn Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/gradient_button_cell.h
diff --git a/chrome/browser/ui/cocoa/gradient_button_cell.h b/chrome/browser/ui/cocoa/gradient_button_cell.h
index c495356ebfb2715513bc26efb536a0b2a01eed7e..00168f1743f5cd660569bf917a5c76c612fe56db 100644
--- a/chrome/browser/ui/cocoa/gradient_button_cell.h
+++ b/chrome/browser/ui/cocoa/gradient_button_cell.h
@@ -45,8 +45,8 @@ typedef enum {
// In motion which will end in a stable state.
kPulsingOn,
kPulsingOff,
- // In continuous motion.
- kPulsingContinuous,
+ // Continuously illuminated, used to highlight buttons.
+ kPulsingStuckOn,
} PulseState;
};
@@ -63,7 +63,6 @@ typedef enum {
NSTimeInterval lastHoverUpdate_;
base::scoped_nsobject<NSGradient> gradient_;
gradient_button_cell::PulseState pulseState_;
- CGFloat pulseMultiplier_; // for selecting pulse direction when continuous.
CGFloat outerStrokeAlphaMult_; // For pulsing.
base::scoped_nsobject<NSImage> overlayImage_;
}
@@ -91,14 +90,13 @@ typedef enum {
- (NSBezierPath*)clipPathForFrame:(NSRect)cellFrame
inView:(NSView*)controlView;
-// Turn on or off continuous pulsing. When turning off continuous
-// pulsing, leave our pulse state in the correct ending position for
-// our isMouseInside_ property. Public since it's called from the
-// bookmark bubble.
-- (void)setIsContinuousPulsing:(BOOL)continuous;
+// Turn on or off pulse sticking. When turning off sticking, leave our pulse
+// state in the correct ending position for our isMouseInside_ property. Public
+// since it's called from the bookmark bubble.
+- (void)setPulseIsStuckOn:(BOOL)continuous;
// Returns continuous pulse state.
-- (BOOL)isContinuousPulsing;
+- (BOOL)isPulseStuckOn;
// Safely stop continuous pulsing by turning off all timers.
// May leave the cell in an odd state.
« no previous file with comments | « chrome/browser/ui/cocoa/bookmarks/bookmark_button.mm ('k') | chrome/browser/ui/cocoa/gradient_button_cell.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698