Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2917)

Unified Diff: chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller_unittest.mm

Issue 2407343002: cocoa browser: fix meaning of "continuous pulsing" (Closed)
Patch Set: setIsContinuousPulsing -> setPulseIsStuckOn Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller_unittest.mm
diff --git a/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller_unittest.mm b/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller_unittest.mm
index 96c3088c0e8c5d12378b083fac9bf64424c9c45f..8836ec2c4a736b6542a3eb4c310e63ce13b62b74 100644
--- a/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller_unittest.mm
+++ b/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller_unittest.mm
@@ -2117,11 +2117,11 @@ void SetUp() override {
ASCIIToUTF16("title"), gurl);
BookmarkButton* button = [[bar_ buttons] objectAtIndex:0];
- EXPECT_FALSE([button isContinuousPulsing]);
+ EXPECT_FALSE([button isPulseStuckOn]);
[bar_ startPulsingBookmarkNode:node];
- EXPECT_TRUE([button isContinuousPulsing]);
+ EXPECT_TRUE([button isPulseStuckOn]);
[bar_ stopPulsingBookmarkNode];
- EXPECT_FALSE([button isContinuousPulsing]);
+ EXPECT_FALSE([button isPulseStuckOn]);
// Pulsing a node within a folder should pulse the folder button.
const BookmarkNode* folder =
@@ -2130,26 +2130,26 @@ void SetUp() override {
model->AddURL(folder, folder->child_count(), ASCIIToUTF16("inner"), gurl);
BookmarkButton* folder_button = [[bar_ buttons] objectAtIndex:1];
- EXPECT_FALSE([folder_button isContinuousPulsing]);
+ EXPECT_FALSE([folder_button isPulseStuckOn]);
[bar_ startPulsingBookmarkNode:inner];
- EXPECT_TRUE([folder_button isContinuousPulsing]);
+ EXPECT_TRUE([folder_button isPulseStuckOn]);
[bar_ stopPulsingBookmarkNode];
- EXPECT_FALSE([folder_button isContinuousPulsing]);
+ EXPECT_FALSE([folder_button isPulseStuckOn]);
// Stop pulsing if the node moved.
[bar_ startPulsingBookmarkNode:inner];
- EXPECT_TRUE([folder_button isContinuousPulsing]);
+ EXPECT_TRUE([folder_button isPulseStuckOn]);
const BookmarkNode* folder2 =
model->AddFolder(root, root->child_count(), ASCIIToUTF16("folder2"));
model->Move(inner, folder2, 0);
- EXPECT_FALSE([folder_button isContinuousPulsing]);
+ EXPECT_FALSE([folder_button isPulseStuckOn]);
// Removing a pulsing folder is allowed.
[bar_ startPulsingBookmarkNode:inner];
BookmarkButton* folder2_button = [[bar_ buttons] objectAtIndex:2];
- EXPECT_TRUE([folder2_button isContinuousPulsing]);
+ EXPECT_TRUE([folder2_button isPulseStuckOn]);
model->Remove(folder2);
- EXPECT_FALSE([folder2_button isContinuousPulsing]);
+ EXPECT_FALSE([folder2_button isPulseStuckOn]);
[bar_ stopPulsingBookmarkNode]; // Should not crash.
}
« no previous file with comments | « chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm ('k') | chrome/browser/ui/cocoa/bookmarks/bookmark_button.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698