Move some global feature defines to buildflags

Move some global feature defines to buildflags

Moves
  enable_captive_portal_detection
  enable_hangout_services_extension
  enable_plugin_installation
out of the global features.gni files and moves them into chrome/common's
feature flags buildflag header. This increases encapsulation and reduces the
global #defines passed to all compiles.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
TBR=jschuh (render_messages.h)

Committed: https://crrev.com/ab78fefbe385452fae85587b505bcc1bac60a17f
Cr-Commit-Position: refs/heads/master@{#424659}

[brettw, 2016-10-10 22:19:12]

Description was changed from

==========
Move some global feature defines to buildflags

Moves
  enable_captive_portal_detection
  enable_hangout_services_extension
  enable_plugin_installation
out of the global features.gni files and moves them into chrome/common's
feature flags buildflag header. This increases encapsulation and reduces the
global #defines passed to all compiles.
==========

to

==========
Move some global feature defines to buildflags

Moves
  enable_captive_portal_detection
  enable_hangout_services_extension
  enable_plugin_installation
out of the global features.gni files and moves them into chrome/common's
feature flags buildflag header. This increases encapsulation and reduces the
global #defines passed to all compiles.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[brettw, 2016-10-10 22:43:14]

Comment

[brettw, 2016-10-10 22:43:14]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-10 22:43:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-11 00:57:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-11 00:57:23]

Dry run: This issue passed the CQ dry run.

[brettw, 2016-10-11 22:50:54]

brettw@chromium.org changed reviewers:
+ thestig@chromium.org

[Lei Zhang, 2016-10-11 23:05:07]

lgtm

[brettw, 2016-10-11 23:16:05]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2016-10-11 23:16:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-11 23:29:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-11 23:29:05]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[brettw, 2016-10-11 23:39:20]

Description was changed from

==========
Move some global feature defines to buildflags

Moves
  enable_captive_portal_detection
  enable_hangout_services_extension
  enable_plugin_installation
out of the global features.gni files and moves them into chrome/common's
feature flags buildflag header. This increases encapsulation and reduces the
global #defines passed to all compiles.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Move some global feature defines to buildflags

Moves
  enable_captive_portal_detection
  enable_hangout_services_extension
  enable_plugin_installation
out of the global features.gni files and moves them into chrome/common's
feature flags buildflag header. This increases encapsulation and reduces the
global #defines passed to all compiles.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
TBR=jschuh (render_messages.h)
==========

[brettw, 2016-10-11 23:39:20]

brettw@chromium.org changed reviewers:
+ jschuh@chromium.org

[brettw, 2016-10-11 23:39:34]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2016-10-11 23:40:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-12 02:56:31]

Description was changed from

==========
Move some global feature defines to buildflags

Moves
  enable_captive_portal_detection
  enable_hangout_services_extension
  enable_plugin_installation
out of the global features.gni files and moves them into chrome/common's
feature flags buildflag header. This increases encapsulation and reduces the
global #defines passed to all compiles.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
TBR=jschuh (render_messages.h)
==========

to

==========
Move some global feature defines to buildflags

Moves
  enable_captive_portal_detection
  enable_hangout_services_extension
  enable_plugin_installation
out of the global features.gni files and moves them into chrome/common's
feature flags buildflag header. This increases encapsulation and reduces the
global #defines passed to all compiles.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
TBR=jschuh (render_messages.h)
==========

[commit-bot: I haz the power, 2016-10-12 02:56:32]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-12 02:58:43]

Description was changed from

==========
Move some global feature defines to buildflags

Moves
  enable_captive_portal_detection
  enable_hangout_services_extension
  enable_plugin_installation
out of the global features.gni files and moves them into chrome/common's
feature flags buildflag header. This increases encapsulation and reduces the
global #defines passed to all compiles.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
TBR=jschuh (render_messages.h)
==========

to

==========
Move some global feature defines to buildflags

Moves
  enable_captive_portal_detection
  enable_hangout_services_extension
  enable_plugin_installation
out of the global features.gni files and moves them into chrome/common's
feature flags buildflag header. This increases encapsulation and reduces the
global #defines passed to all compiles.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
TBR=jschuh (render_messages.h)

Committed: https://crrev.com/ab78fefbe385452fae85587b505bcc1bac60a17f
Cr-Commit-Position: refs/heads/master@{#424659}
==========

[commit-bot: I haz the power, 2016-10-12 02:58:44]

Patchset 2 (id:??) landed as
https://crrev.com/ab78fefbe385452fae85587b505bcc1bac60a17f
Cr-Commit-Position: refs/heads/master@{#424659}