chrome/browser/guest_view/web_view/chrome_web_view_permission_helper_delegate.h - Issue 2405013002: Move some global feature defines to buildflags

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/guest_view/web_view/chrome_web_view_permission_helper_delegate.h

Issue 2405013002: Move some global feature defines to buildflags (Closed)

Patch Set: Comment Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/component_loader.cc ('k') | chrome/browser/guest_view/web_view/chrome_web_view_permission_helper_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/guest_view/web_view/chrome_web_view_permission_helper_delegate.h

diff --git a/chrome/browser/guest_view/web_view/chrome_web_view_permission_helper_delegate.h b/chrome/browser/guest_view/web_view/chrome_web_view_permission_helper_delegate.h

index 64a21c95c34660bd387033e3350dbacaa1071824..36885e69334a7671f869d4ebba468f4b520bc8fa 100644

--- a/chrome/browser/guest_view/web_view/chrome_web_view_permission_helper_delegate.h

+++ b/chrome/browser/guest_view/web_view/chrome_web_view_permission_helper_delegate.h

@@ -6,6 +6,7 @@

#define CHROME_BROWSER_GUEST_VIEW_WEB_VIEW_CHROME_WEB_VIEW_PERMISSION_HELPER_DELEGATE_H_

#include "base/macros.h"

+#include "chrome/common/features.h"

#include "extensions/browser/guest_view/web_view/web_view_permission_helper.h"

#include "extensions/browser/guest_view/web_view/web_view_permission_helper_delegate.h"

#include "third_party/WebKit/public/platform/modules/permissions/permission_status.mojom.h"

@@ -64,11 +65,11 @@ class ChromeWebViewPermissionHelperDelegate :

void OnBlockedOutdatedPlugin(int placeholder_id,

const std::string& identifier);

void OnOpenAboutPlugins();

-#if defined(ENABLE_PLUGIN_INSTALLATION)

+#if BUILDFLAG(ENABLE_PLUGIN_INSTALLATION)

void OnFindMissingPlugin(int placeholder_id, const std::string& mime_type);

void OnRemovePluginPlaceholderHost(int placeholder_id);

-#endif // defined(ENABLE_PLUGIN_INSTALLATION)

+#endif // BUILDFLAG(ENABLE_PLUGIN_INSTALLATION)

void OnPermissionResponse(const std::string& identifier,

bool allow,