Move enable_app_list to a buildflag.

Move enable_app_list to a buildflag.

This flag is only used in Chrome so can be moved to the chrome feature flags.

The root build file reference is removed. This target will be discovered in the
cource of a build with app_list enabled anyway, and having the root file refer
to chrome's features is a layering violation.

This adds several missing dependencies on generated headers in the ChromeOS
build I noticed when testing this patch.

The chrome_grit_defines are now used for all grit targets under //chrome.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/d1bc9dafdb5b3cca4e62a84bfbbe8be4145aa6fb
Cr-Commit-Position: refs/heads/master@{#425411}

[brettw, 2016-10-11 18:16:27]

Description was changed from

==========
Move enable_app_list to a buildflag.

This flag is only used in Chrome so can be moved to the chrome feature flags.

The root build file reference is removed. This targe twill be discovered in the
cource of a build with app_list enabled anyway, and having the root file refer
to chrome's features is a layering violation.
==========

to

==========
Move enable_app_list to a buildflag.

This flag is only used in Chrome so can be moved to the chrome feature flags.

The root build file reference is removed. This targe twill be discovered in the
cource of a build with app_list enabled anyway, and having the root file refer
to chrome's features is a layering violation.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[brettw, 2016-10-11 18:23:07]

brettw@chromium.org changed reviewers:
+ jamescook@chromium.org, jschuh@chromium.org

[brettw, 2016-10-11 18:23:24]

Description was changed from

==========
Move enable_app_list to a buildflag.

This flag is only used in Chrome so can be moved to the chrome feature flags.

The root build file reference is removed. This targe twill be discovered in the
cource of a build with app_list enabled anyway, and having the root file refer
to chrome's features is a layering violation.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Move enable_app_list to a buildflag.

This flag is only used in Chrome so can be moved to the chrome feature flags.

The root build file reference is removed. This targe twill be discovered in the
cource of a build with app_list enabled anyway, and having the root file refer
to chrome's features is a layering violation.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

TBR=jschuh (render_messages.h)
==========

[brettw, 2016-10-11 18:23:29]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-11 18:23:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-11 19:11:03]

The CQ bit was unchecked by commit-bot@chromium.org

[James Cook, 2016-10-11 19:11:04]

I'm not particularly familiar with the app list, nor with build feature config,
but this seems pretty straightforward, so LGTM

[commit-bot: I haz the power, 2016-10-11 19:11:04]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[brettw, 2016-10-11 19:29:18]

Fixes

[brettw, 2016-10-11 19:29:19]

The CQ bit was checked by brettw@chromium.org

[brettw, 2016-10-11 19:29:20]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamescook@chromium.org
Link to the patchset: https://codereview.chromium.org/2406303003/#ps40001
(title: "Fixes")

[commit-bot: I haz the power, 2016-10-11 19:30:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-11 19:34:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-11 19:34:37]

Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[brettw, 2016-10-11 19:58:58]

Description was changed from

==========
Move enable_app_list to a buildflag.

This flag is only used in Chrome so can be moved to the chrome feature flags.

The root build file reference is removed. This targe twill be discovered in the
cource of a build with app_list enabled anyway, and having the root file refer
to chrome's features is a layering violation.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

TBR=jschuh (render_messages.h)
==========

to

==========
Move enable_app_list to a buildflag.

This flag is only used in Chrome so can be moved to the chrome feature flags.

The root build file reference is removed. This targe twill be discovered in the
cource of a build with app_list enabled anyway, and having the root file refer
to chrome's features is a layering violation.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[brettw, 2016-10-11 19:58:58]

brettw@chromium.org changed reviewers:
- jschuh@chromium.org

[brettw, 2016-10-11 21:37:51]

Fix merge

[brettw, 2016-10-11 21:37:52]

The CQ bit was checked by brettw@chromium.org

[brettw, 2016-10-11 21:37:53]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamescook@chromium.org
Link to the patchset: https://codereview.chromium.org/2406303003/#ps60001
(title: "Fix merge")

[commit-bot: I haz the power, 2016-10-11 21:38:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-11 21:49:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-11 21:49:20]

Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[brettw, 2016-10-11 22:26:14]

Fix

[brettw, 2016-10-11 22:26:15]

The CQ bit was checked by brettw@chromium.org

[brettw, 2016-10-11 22:26:16]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamescook@chromium.org
Link to the patchset: https://codereview.chromium.org/2406303003/#ps80001
(title: "Fix")

[commit-bot: I haz the power, 2016-10-11 22:26:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-11 22:37:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-11 22:37:20]

Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[brettw, 2016-10-11 23:41:22]

Fixes

[brettw, 2016-10-11 23:41:23]

The CQ bit was checked by brettw@chromium.org

[brettw, 2016-10-11 23:41:24]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamescook@chromium.org
Link to the patchset: https://codereview.chromium.org/2406303003/#ps100001
(title: "Fixes")

[brettw, 2016-10-11 23:41:35]

Description was changed from

==========
Move enable_app_list to a buildflag.

This flag is only used in Chrome so can be moved to the chrome feature flags.

The root build file reference is removed. This targe twill be discovered in the
cource of a build with app_list enabled anyway, and having the root file refer
to chrome's features is a layering violation.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Move enable_app_list to a buildflag.

This flag is only used in Chrome so can be moved to the chrome feature flags.

The root build file reference is removed. This targe twill be discovered in the
cource of a build with app_list enabled anyway, and having the root file refer
to chrome's features is a layering violation.

This adds several missing dependencies on generated headers in the ChromeOS
build I noticed when testing this patch.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-10-11 23:41:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-12 01:43:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-12 01:43:08]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[brettw, 2016-10-12 03:30:22]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2016-10-12 03:30:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-12 03:34:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-12 03:35:01]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[brettw, 2016-10-12 19:29:45]

Merge

[brettw, 2016-10-12 19:29:46]

The CQ bit was checked by brettw@chromium.org

[brettw, 2016-10-12 19:29:47]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamescook@chromium.org
Link to the patchset: https://codereview.chromium.org/2406303003/#ps120001
(title: "Merge")

[commit-bot: I haz the power, 2016-10-12 19:30:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-12 22:43:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-12 22:43:19]

Exceeded global retry quota

[brettw, 2016-10-14 17:19:52]

Description was changed from

==========
Move enable_app_list to a buildflag.

This flag is only used in Chrome so can be moved to the chrome feature flags.

The root build file reference is removed. This targe twill be discovered in the
cource of a build with app_list enabled anyway, and having the root file refer
to chrome's features is a layering violation.

This adds several missing dependencies on generated headers in the ChromeOS
build I noticed when testing this patch.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Move enable_app_list to a buildflag.

This flag is only used in Chrome so can be moved to the chrome feature flags.

The root build file reference is removed. This target will be discovered in the
cource of a build with app_list enabled anyway, and having the root file refer
to chrome's features is a layering violation.

This adds several missing dependencies on generated headers in the ChromeOS
build I noticed when testing this patch.

The chrome_grit_defines are now used for all grit targets under //chrome.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[brettw, 2016-10-14 17:20:39]

More grit defines

[brettw, 2016-10-14 17:20:40]

The CQ bit was checked by brettw@chromium.org

[brettw, 2016-10-14 17:20:41]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamescook@chromium.org
Link to the patchset: https://codereview.chromium.org/2406303003/#ps140001
(title: "More grit defines")

[commit-bot: I haz the power, 2016-10-14 17:21:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-14 19:04:49]

Description was changed from

==========
Move enable_app_list to a buildflag.

This flag is only used in Chrome so can be moved to the chrome feature flags.

The root build file reference is removed. This target will be discovered in the
cource of a build with app_list enabled anyway, and having the root file refer
to chrome's features is a layering violation.

This adds several missing dependencies on generated headers in the ChromeOS
build I noticed when testing this patch.

The chrome_grit_defines are now used for all grit targets under //chrome.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Move enable_app_list to a buildflag.

This flag is only used in Chrome so can be moved to the chrome feature flags.

The root build file reference is removed. This target will be discovered in the
cource of a build with app_list enabled anyway, and having the root file refer
to chrome's features is a layering violation.

This adds several missing dependencies on generated headers in the ChromeOS
build I noticed when testing this patch.

The chrome_grit_defines are now used for all grit targets under //chrome.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-10-14 19:04:51]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2016-10-14 19:08:33]

Description was changed from

==========
Move enable_app_list to a buildflag.

This flag is only used in Chrome so can be moved to the chrome feature flags.

The root build file reference is removed. This target will be discovered in the
cource of a build with app_list enabled anyway, and having the root file refer
to chrome's features is a layering violation.

This adds several missing dependencies on generated headers in the ChromeOS
build I noticed when testing this patch.

The chrome_grit_defines are now used for all grit targets under //chrome.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Move enable_app_list to a buildflag.

This flag is only used in Chrome so can be moved to the chrome feature flags.

The root build file reference is removed. This target will be discovered in the
cource of a build with app_list enabled anyway, and having the root file refer
to chrome's features is a layering violation.

This adds several missing dependencies on generated headers in the ChromeOS
build I noticed when testing this patch.

The chrome_grit_defines are now used for all grit targets under //chrome.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/d1bc9dafdb5b3cca4e62a84bfbbe8be4145aa6fb
Cr-Commit-Position: refs/heads/master@{#425411}
==========

[commit-bot: I haz the power, 2016-10-14 19:08:35]

Patchset 8 (id:??) landed as
https://crrev.com/d1bc9dafdb5b3cca4e62a84bfbbe8be4145aa6fb
Cr-Commit-Position: refs/heads/master@{#425411}