Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(506)

Side by Side Diff: build/config/features.gni

Issue 2405013002: Move some global feature defines to buildflags (Closed)
Patch Set: Comment Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « build/config/BUILD.gn ('k') | chrome/browser/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # ============================================= 5 # =============================================
6 # PLEASE DO NOT ADD MORE FLAGS TO THIS FILE 6 # PLEASE DO NOT ADD MORE FLAGS TO THIS FILE
7 # ============================================= 7 # =============================================
8 # 8 #
9 # These flags are effectively global. Your feature flag should go near the 9 # These flags are effectively global. Your feature flag should go near the
10 # code it controls. Most of these items are here now because they control 10 # code it controls. Most of these items are here now because they control
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
46 # Enables WebRTC. 46 # Enables WebRTC.
47 enable_webrtc = !is_ios 47 enable_webrtc = !is_ios
48 48
49 # Enables the Media Router. 49 # Enables the Media Router.
50 enable_media_router = !is_ios && !is_chromecast 50 enable_media_router = !is_ios && !is_chromecast
51 51
52 # Enables proprietary codecs and demuxers; e.g. H264, AAC, MP3, and MP4. 52 # Enables proprietary codecs and demuxers; e.g. H264, AAC, MP3, and MP4.
53 # We always build Google Chrome and Chromecast with proprietary codecs. 53 # We always build Google Chrome and Chromecast with proprietary codecs.
54 proprietary_codecs = is_chrome_branded || is_chromecast 54 proprietary_codecs = is_chrome_branded || is_chromecast
55 55
56 enable_captive_portal_detection = !is_android && !is_ios && !is_chromecast
57
58 # Enables use of the session service, which is enabled by default. 56 # Enables use of the session service, which is enabled by default.
59 # Android stores them separately on the Java side. 57 # Android stores them separately on the Java side.
60 enable_session_service = !is_android && !is_ios && !is_chromecast 58 enable_session_service = !is_android && !is_ios && !is_chromecast
61 59
62 enable_plugin_installation = is_win || is_mac
63
64 enable_app_list = is_chromeos 60 enable_app_list = is_chromeos
65 61
66 enable_supervised_users = !is_ios && !is_chromecast 62 enable_supervised_users = !is_ios && !is_chromecast
67 63
68 enable_remoting = !is_ios && !is_chromecast 64 enable_remoting = !is_ios && !is_chromecast
69 65
70 # Hangout services is an extension that adds extra features to Hangouts.
71 # For official GYP builds, this flag is set.
72 enable_hangout_services_extension = false
73
74 # Variable safe_browsing is used to control the build time configuration for 66 # Variable safe_browsing is used to control the build time configuration for
75 # safe browsing feature. Safe browsing can be compiled in 3 different levels: 67 # safe browsing feature. Safe browsing can be compiled in 3 different levels:
76 # 0 disables it, 1 enables it fully, and 2 enables mobile protection via an 68 # 0 disables it, 1 enables it fully, and 2 enables mobile protection via an
77 # external API. 69 # external API.
78 if (is_ios || is_chromecast) { 70 if (is_ios || is_chromecast) {
79 safe_browsing_mode = 0 71 safe_browsing_mode = 0
80 } else if (is_android) { 72 } else if (is_android) {
81 safe_browsing_mode = 2 73 safe_browsing_mode = 2
82 } else { 74 } else {
83 safe_browsing_mode = 1 75 safe_browsing_mode = 1
(...skipping 88 matching lines...) Expand 10 before | Expand all | Expand 10 after
172 164
173 enable_configuration_policy = !is_ios 165 enable_configuration_policy = !is_ios
174 166
175 enable_mac_keystone = is_mac && is_chrome_branded && is_official_build 167 enable_mac_keystone = is_mac && is_chrome_branded && is_official_build
176 # 168 #
177 # ============================================= 169 # =============================================
178 # PLEASE DO NOT ADD MORE FLAGS TO THIS FILE 170 # PLEASE DO NOT ADD MORE FLAGS TO THIS FILE
179 # ============================================= 171 # =============================================
180 # 172 #
181 # See comment at the top. 173 # See comment at the top.
OLDNEW
« no previous file with comments | « build/config/BUILD.gn ('k') | chrome/browser/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698