Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2511)

Unified Diff: chrome/browser/guest_view/web_view/chrome_web_view_permission_helper_delegate.cc

Issue 2405013002: Move some global feature defines to buildflags (Closed)
Patch Set: Comment Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/guest_view/web_view/chrome_web_view_permission_helper_delegate.cc
diff --git a/chrome/browser/guest_view/web_view/chrome_web_view_permission_helper_delegate.cc b/chrome/browser/guest_view/web_view/chrome_web_view_permission_helper_delegate.cc
index 6fc53e385d48e177d0f1bbe6f87d30882f6f15e3..57d0bd5aab3686a98037326399d852fb2b7aeff4 100644
--- a/chrome/browser/guest_view/web_view/chrome_web_view_permission_helper_delegate.cc
+++ b/chrome/browser/guest_view/web_view/chrome_web_view_permission_helper_delegate.cc
@@ -9,6 +9,7 @@
#include "chrome/browser/permissions/permission_request_id.h"
#include "chrome/browser/plugins/chrome_plugin_service_filter.h"
#include "chrome/browser/profiles/profile.h"
+#include "chrome/common/features.h"
#include "chrome/common/render_messages.h"
#include "content/public/browser/permission_type.h"
#include "content/public/browser/render_frame_host.h"
@@ -60,7 +61,7 @@ bool ChromeWebViewPermissionHelperDelegate::OnMessageReceived(
OnCouldNotLoadPlugin)
IPC_MESSAGE_HANDLER(ChromeViewHostMsg_OpenAboutPlugins,
OnOpenAboutPlugins)
-#if defined(ENABLE_PLUGIN_INSTALLATION)
+#if BUILDFLAG(ENABLE_PLUGIN_INSTALLATION)
IPC_MESSAGE_HANDLER(ChromeViewHostMsg_RemovePluginPlaceholderHost,
OnRemovePluginPlaceholderHost)
#endif
@@ -102,11 +103,11 @@ void ChromeWebViewPermissionHelperDelegate::OnBlockedOutdatedPlugin(
void ChromeWebViewPermissionHelperDelegate::OnOpenAboutPlugins() {
}
-#if defined(ENABLE_PLUGIN_INSTALLATION)
+#if BUILDFLAG(ENABLE_PLUGIN_INSTALLATION)
void ChromeWebViewPermissionHelperDelegate::OnRemovePluginPlaceholderHost(
int placeholder_id) {
}
-#endif // defined(ENABLE_PLUGIN_INSTALLATION)
+#endif // BUILDFLAG(ENABLE_PLUGIN_INSTALLATION)
void ChromeWebViewPermissionHelperDelegate::OnPermissionResponse(
const std::string& identifier,

Powered by Google App Engine
This is Rietveld 408576698