Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(672)

Issue 2403113004: Add new background abort type. (Closed)

Created:
4 years, 2 months ago by Bryan McQuade
Modified:
4 years, 2 months ago
CC:
chromium-reviews, csharrison+watch_chromium.org, loading-reviews+metrics_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add new background abort type. These new metrics will replace the existing NavigationToFirstBackground metrics, which will be removed after it is determined that the new and old metrics are logging similar values for a few days in canary. Note that these histograms do log under slightly different conditions, so are not expected to log identical values. BUG=654430 Committed: https://crrev.com/3f54b6c611497a48e138d03555be0388c11d60dc Cr-Commit-Position: refs/heads/master@{#424635}

Patch Set 1 #

Patch Set 2 : formatting #

Patch Set 3 : add histograms.xml entry #

Patch Set 4 : formatting #

Patch Set 5 : fix tests #

Messages

Total messages: 28 (21 generated)
Bryan McQuade
PTAL, thanks!
4 years, 2 months ago (2016-10-11 02:11:32 UTC) #10
Charlie Harrison
lgtm
4 years, 2 months ago (2016-10-11 12:27:13 UTC) #20
Bryan McQuade
isherman, PTAL for histograms.xml, thanks!
4 years, 2 months ago (2016-10-11 14:22:49 UTC) #22
Ilya Sherman
metrics lgtm
4 years, 2 months ago (2016-10-11 23:49:34 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2403113004/80001
4 years, 2 months ago (2016-10-12 01:22:19 UTC) #25
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 2 months ago (2016-10-12 01:28:37 UTC) #26
commit-bot: I haz the power
4 years, 2 months ago (2016-10-12 01:32:38 UTC) #28
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/3f54b6c611497a48e138d03555be0388c11d60dc
Cr-Commit-Position: refs/heads/master@{#424635}

Powered by Google App Engine
This is Rietveld 408576698