Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1125)

Unified Diff: chrome/browser/page_load_metrics/metrics_web_contents_observer.cc

Issue 2403113004: Add new background abort type. (Closed)
Patch Set: fix tests Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/page_load_metrics/metrics_web_contents_observer.cc
diff --git a/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc b/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc
index 8e0eeb873481d957375f4cbffd01ad1ead3f90d5..937a8edae11862e41d3523712affa5a2c229ba5c 100644
--- a/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc
+++ b/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc
@@ -423,6 +423,13 @@ void PageLoadTracker::WebContentsHidden() {
DCHECK_EQ(started_in_foreground_, foreground_time_.is_null());
background_time_ = base::TimeTicks::Now();
ClampBrowserTimestampIfInterProcessTimeTickSkew(&background_time_);
+ // Though most cases where a tab is backgrounded are user initiated, we
+ // can't be certain that we were backgrounded due to a user action. For
+ // example, on Android, the screen times out after a period of inactivity,
+ // resulting in a non-user-initiated backgrounding.
+ const bool abort_is_user_initiated = false;
+ NotifyAbort(ABORT_BACKGROUND, abort_is_user_initiated, background_time_,
+ true);
}
for (const auto& observer : observers_)
« no previous file with comments | « no previous file | chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698