Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(586)

Unified Diff: chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.cc

Issue 2403113004: Add new background abort type. (Closed)
Patch Set: fix tests Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.cc
diff --git a/chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.cc b/chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.cc
index f67d5827dd9bd15dfd9cdec6a1acf6ced327c312..412795a5f1bbbf1358cf71c6a4a4f137e1180604 100644
--- a/chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.cc
+++ b/chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.cc
@@ -81,6 +81,14 @@ const char kHistogramFromGWSAbortForwardBackBeforePaint[] =
const char kHistogramFromGWSAbortForwardBackBeforeInteraction[] =
"PageLoad.Clients.FromGoogleSearch.AbortTiming.ForwardBackNavigation."
"AfterPaint.Before1sDelayedInteraction";
+const char kHistogramFromGWSAbortBackgroundBeforeCommit[] =
+ "PageLoad.Clients.FromGoogleSearch.AbortTiming.Background.BeforeCommit";
+const char kHistogramFromGWSAbortBackgroundBeforePaint[] =
+ "PageLoad.Clients.FromGoogleSearch.AbortTiming.Background.AfterCommit."
+ "BeforePaint";
+const char kHistogramFromGWSAbortBackgroundBeforeInteraction[] =
+ "PageLoad.Clients.FromGoogleSearch.AbortTiming.Background.AfterPaint."
+ "BeforeInteraction";
} // namespace internal
@@ -111,6 +119,10 @@ void LogCommittedAbortsBeforePaint(UserAbortType abort_type,
internal::kHistogramFromGWSAbortForwardBackBeforePaint,
time_to_abort);
break;
+ case UserAbortType::ABORT_BACKGROUND:
+ PAGE_LOAD_HISTOGRAM(internal::kHistogramFromGWSAbortBackgroundBeforePaint,
+ time_to_abort);
+ break;
default:
// These should only be logged for provisional aborts.
DCHECK_NE(abort_type, UserAbortType::ABORT_OTHER);
@@ -145,6 +157,11 @@ void LogAbortsAfterPaintBeforeInteraction(UserAbortType abort_type,
internal::kHistogramFromGWSAbortForwardBackBeforeInteraction,
time_to_abort);
break;
+ case UserAbortType::ABORT_BACKGROUND:
+ PAGE_LOAD_HISTOGRAM(
+ internal::kHistogramFromGWSAbortBackgroundBeforeInteraction,
+ time_to_abort);
+ break;
default:
// These should only be logged for provisional aborts.
DCHECK_NE(abort_type, UserAbortType::ABORT_OTHER);
@@ -181,6 +198,11 @@ void LogProvisionalAborts(UserAbortType abort_type,
internal::kHistogramFromGWSAbortForwardBackBeforeCommit,
time_to_abort);
break;
+ case UserAbortType::ABORT_BACKGROUND:
+ PAGE_LOAD_HISTOGRAM(
+ internal::kHistogramFromGWSAbortBackgroundBeforeCommit,
+ time_to_abort);
+ break;
default:
NOTREACHED();
break;

Powered by Google App Engine
This is Rietveld 408576698