Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(699)

Unified Diff: chrome/browser/page_load_metrics/page_load_metrics_observer.h

Issue 2403113004: Add new background abort type. (Closed)
Patch Set: fix tests Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/page_load_metrics_observer.h
diff --git a/chrome/browser/page_load_metrics/page_load_metrics_observer.h b/chrome/browser/page_load_metrics/page_load_metrics_observer.h
index 4e1c556cb47174c64654c63e5bb9e224617b42e9..7656e27a2f4117d0ba53a20e5d55436f6ace1d82 100644
--- a/chrome/browser/page_load_metrics/page_load_metrics_observer.h
+++ b/chrome/browser/page_load_metrics/page_load_metrics_observer.h
@@ -32,17 +32,22 @@ enum UserAbortType {
// meta refresh tag.
ABORT_CLIENT_REDIRECT,
- // If the navigation is replaced by a new navigation. This includes link
+ // If the page load is replaced by a new navigation. This includes link
// clicks, typing in the omnibox (not a reload), and form submissions.
ABORT_NEW_NAVIGATION,
// If the user presses the stop X button.
ABORT_STOP,
- // If the navigation is aborted by closing the tab or browser.
+ // If the page load is aborted by closing the tab or browser.
ABORT_CLOSE,
- // We don't know why the navigation aborted. This is the value we assign to an
+ // The page load was backgrounded, e.g. the browser was minimized or the user
+ // switched tabs. Note that the same page may be foregrounded in the future,
+ // so this is not a 'terminal' abort type.
+ ABORT_BACKGROUND,
+
+ // We don't know why the page load aborted. This is the value we assign to an
// aborted load if the only signal we get is a provisional load finishing
// without committing, either without error or with net::ERR_ABORTED.
ABORT_OTHER,

Powered by Google App Engine
This is Rietveld 408576698