Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1580)

Unified Diff: chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer.cc

Issue 2403113004: Add new background abort type. (Closed)
Patch Set: fix tests Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer.cc
diff --git a/chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer.cc b/chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer.cc
index 2b64a060e9176d994f501d52b2c7398d6cfcee64..79b185213b34be904e8cc4993a7450d4d8734989 100644
--- a/chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer.cc
+++ b/chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer.cc
@@ -22,6 +22,8 @@ const char kHistogramAbortStopBeforeCommit[] =
"PageLoad.AbortTiming.Stop.BeforeCommit";
const char kHistogramAbortCloseBeforeCommit[] =
"PageLoad.AbortTiming.Close.BeforeCommit";
+const char kHistogramAbortBackgroundBeforeCommit[] =
+ "PageLoad.AbortTiming.Background.BeforeCommit";
const char kHistogramAbortOtherBeforeCommit[] =
"PageLoad.AbortTiming.Other.BeforeCommit";
@@ -37,6 +39,8 @@ const char kHistogramAbortStopBeforePaint[] =
"PageLoad.AbortTiming.Stop.AfterCommit.BeforePaint";
const char kHistogramAbortCloseBeforePaint[] =
"PageLoad.AbortTiming.Close.AfterCommit.BeforePaint";
+const char kHistogramAbortBackgroundBeforePaint[] =
+ "PageLoad.AbortTiming.Background.AfterCommit.BeforePaint";
const char kHistogramAbortClientRedirectDuringParse[] =
"PageLoad.AbortTiming.ClientRedirect.DuringParse";
@@ -50,6 +54,8 @@ const char kHistogramAbortStopDuringParse[] =
"PageLoad.AbortTiming.Stop.DuringParse";
const char kHistogramAbortCloseDuringParse[] =
"PageLoad.AbortTiming.Close.DuringParse";
+const char kHistogramAbortBackgroundDuringParse[] =
+ "PageLoad.AbortTiming.Background.DuringParse";
// These metrics should be temporary until we have landed on a one-size-fits-all
// abort metric.
@@ -108,6 +114,10 @@ void RecordAbortBeforeCommit(UserAbortType abort_type,
PAGE_LOAD_HISTOGRAM(internal::kHistogramAbortCloseBeforeCommit,
time_to_abort);
return;
+ case UserAbortType::ABORT_BACKGROUND:
+ PAGE_LOAD_HISTOGRAM(internal::kHistogramAbortBackgroundBeforeCommit,
+ time_to_abort);
+ return;
case UserAbortType::ABORT_OTHER:
PAGE_LOAD_HISTOGRAM(internal::kHistogramAbortOtherBeforeCommit,
time_to_abort);
@@ -147,6 +157,10 @@ void RecordAbortAfterCommitBeforePaint(UserAbortType abort_type,
PAGE_LOAD_HISTOGRAM(internal::kHistogramAbortCloseBeforePaint,
time_to_abort);
return;
+ case UserAbortType::ABORT_BACKGROUND:
+ PAGE_LOAD_HISTOGRAM(internal::kHistogramAbortBackgroundBeforePaint,
+ time_to_abort);
+ return;
case UserAbortType::ABORT_OTHER:
NOTREACHED() << "Received UserAbortType::ABORT_OTHER for committed load.";
return;
@@ -185,6 +199,10 @@ void RecordAbortDuringParse(UserAbortType abort_type,
PAGE_LOAD_HISTOGRAM(internal::kHistogramAbortCloseDuringParse,
time_to_abort);
return;
+ case UserAbortType::ABORT_BACKGROUND:
+ PAGE_LOAD_HISTOGRAM(internal::kHistogramAbortBackgroundDuringParse,
+ time_to_abort);
+ return;
case UserAbortType::ABORT_OTHER:
NOTREACHED() << "Received UserAbortType::ABORT_OTHER for committed load.";
return;

Powered by Google App Engine
This is Rietveld 408576698