Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 2399613002: Don't access Port._filesystem directly (use Port.host.filesystem instead). (Closed)

Created:
4 years, 2 months ago by qyearsley
Modified:
4 years, 2 months ago
Reviewers:
jeffcarp
CC:
blink-reviews, chromium-reviews, Dirk Pranke, ojan
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't access Port._filesystem directly (use Port.host.filesystem instead). In some places, port.host.filesystem is used while in others port._filesystem is used. Since the Port object's copy of the FileSystem object is set based on its Host object, these are the same. The purpose of this CL is to make the codebase more consistent, and it makes it so that Port._filesystem is just a private shortcut attribute, and is not depended upon. BUG=643937 Committed: https://crrev.com/fc9b72ea61eece7cd926669c5ee808af843cfc0d Cr-Commit-Position: refs/heads/master@{#423308}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -70 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py View 2 chunks +9 lines, -4 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/android.py View 3 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py View 4 chunks +15 lines, -13 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/driver.py View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/driver_unittest.py View 1 chunk +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/linux_unittest.py View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/mock_drt.py View 2 chunks +10 lines, -10 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py View 4 chunks +13 lines, -13 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/servers/server_base.py View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/views/printing.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl_unittest.py View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_unittest.py View 5 chunks +17 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
qyearsley
4 years, 2 months ago (2016-10-05 18:35:39 UTC) #2
jeffcarp
lgtm
4 years, 2 months ago (2016-10-05 20:51:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2399613002/1
4 years, 2 months ago (2016-10-05 21:10:24 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-05 21:59:37 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-10-05 22:02:22 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fc9b72ea61eece7cd926669c5ee808af843cfc0d
Cr-Commit-Position: refs/heads/master@{#423308}

Powered by Google App Engine
This is Rietveld 408576698