Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1564)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/driver_unittest.py

Issue 2399613002: Don't access Port._filesystem directly (use Port.host.filesystem instead). (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/driver_unittest.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/driver_unittest.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/driver_unittest.py
index d03200122955148c5877d041ec907f5553e4536b..2593266f5bdad4abe17d53dadc01a9ee0517dd32 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/driver_unittest.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/driver_unittest.py
@@ -217,27 +217,27 @@ class DriverTest(unittest.TestCase):
def test_creating_a_port_does_not_write_to_the_filesystem(self):
port = TestWebKitPort()
Driver(port, 0, pixel_tests=True)
- self.assertEqual(port._filesystem.written_files, {})
- self.assertIsNone(port._filesystem.last_tmpdir)
+ self.assertEqual(port.host.filesystem.written_files, {})
+ self.assertIsNone(port.host.filesystem.last_tmpdir)
def test_stop_cleans_up_properly(self):
port = TestWebKitPort()
port._server_process_constructor = MockServerProcess
driver = Driver(port, 0, pixel_tests=True)
driver.start(True, [], None)
- last_tmpdir = port._filesystem.last_tmpdir
+ last_tmpdir = port.host.filesystem.last_tmpdir
self.assertIsNotNone(last_tmpdir)
driver.stop()
- self.assertFalse(port._filesystem.isdir(last_tmpdir))
+ self.assertFalse(port.host.filesystem.isdir(last_tmpdir))
def test_two_starts_cleans_up_properly(self):
port = TestWebKitPort()
port._server_process_constructor = MockServerProcess
driver = Driver(port, 0, pixel_tests=True)
driver.start(True, [], None)
- last_tmpdir = port._filesystem.last_tmpdir
+ last_tmpdir = port.host.filesystem.last_tmpdir
driver._start(True, [])
- self.assertFalse(port._filesystem.isdir(last_tmpdir))
+ self.assertFalse(port.host.filesystem.isdir(last_tmpdir))
def test_start_actually_starts(self):
port = TestWebKitPort()

Powered by Google App Engine
This is Rietveld 408576698