third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/driver.py - Issue 2399613002: Don't access Port._filesystem directly (use Port.host.filesystem instead).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/driver.py

Issue 2399613002: Don't access Port._filesystem directly (use Port.host.filesystem instead). (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/driver_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/driver.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/driver.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/driver.py

index 6df3e57fe11741f995354679f6fc21798c78805c..d97e82c32f6ef8e28e4a60058c708c7c2040e63b 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/driver.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/driver.py

@@ -310,7 +310,7 @@ class Driver(object):

def _start(self, pixel_tests, per_test_args, wait_for_ready=True):

self.stop()

- self._driver_tempdir = self._port._filesystem.mkdtemp(prefix='%s-' % self._port.driver_name())

+ self._driver_tempdir = self._port.host.filesystem.mkdtemp(prefix='%s-' % self._port.driver_name())

server_name = self._port.driver_name()

environment = self._port.setup_environ_for_server()

environment = self._setup_environ_for_driver(environment)

@@ -359,7 +359,7 @@ class Driver(object):

self._profiler.profile_after_exit()

if self._driver_tempdir:

- self._port._filesystem.rmtree(str(self._driver_tempdir))

+ self._port.host.filesystem.rmtree(str(self._driver_tempdir))

self._driver_tempdir = None

self._current_cmd_line = None