third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl_unittest.py - Issue 2399613002: Don't access Port._filesystem directly (use Port.host.filesystem instead).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl_unittest.py

Issue 2399613002: Don't access Port._filesystem directly (use Port.host.filesystem instead). (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/views/printing.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl_unittest.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl_unittest.py b/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl_unittest.py

index bf48922a69ab9d67afc6f4e27d6a4316b07ba6de..1c81ae65c010f0df7817f602ce0fb05262fa8981 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl_unittest.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl_unittest.py

@@ -66,7 +66,7 @@ class RebaselineCLTest(BaseTestCase, LoggingTestCase):

]

for test in tests:

# pylint: disable=protected-access

- self._write(port._filesystem.join(port.layout_tests_dir(), test), 'contents')

+ self._write(port.host.filesystem.join(port.layout_tests_dir(), test), 'contents')

def tearDown(self):

BaseTestCase.tearDown(self)

@@ -165,7 +165,7 @@ class RebaselineCLTest(BaseTestCase, LoggingTestCase):

# pylint: disable=protected-access

port = self.tool.port_factory.get('test-win-win7')

self._write(

- port._filesystem.join(port.layout_tests_dir(), 'fast/dom/prototype-taco.html'),

+ port.host.filesystem.join(port.layout_tests_dir(), 'fast/dom/prototype-taco.html'),

'test contents')

self.command._rebaseline(