third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py - Issue 2399613002: Don't access Port._filesystem directly (use Port.host.filesystem instead).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py

Issue 2399613002: Don't access Port._filesystem directly (use Port.host.filesystem instead). (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py

index 1c76bc077a45e0b9a661f5b13a8c8a01b55c5d4c..58f5ee0ccdfb66ec4949d46135d3c5db42810824 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py

@@ -446,13 +446,13 @@ class Manager(object):

sample_files = self._port.look_for_new_samples(crashed_processes, start_time)

if sample_files:

for test, sample_file in sample_files.iteritems():

- writer = TestResultWriter(self._port._filesystem, self._port, self._port.results_directory(), test)

+ writer = TestResultWriter(self._filesystem, self._port, self._port.results_directory(), test)

writer.copy_sample_file(sample_file)

crash_logs = self._port.look_for_new_crash_logs(crashed_processes, start_time)

if crash_logs:

for test, crash_log in crash_logs.iteritems():

- writer = TestResultWriter(self._port._filesystem, self._port, self._port.results_directory(), test)

+ writer = TestResultWriter(self._filesystem, self._port, self._port.results_directory(), test)

writer.write_crash_log(crash_log)

def _clobber_old_results(self):

« no previous file with comments | « no previous file | third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py » ('j') | no next file with comments »