Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 2397873002: Reject some previuosly-escaped chars in hostnames.

Created:
4 years, 2 months ago by brettw
Modified:
4 years, 1 month ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reject some previuosly-escaped chars in hostnames. Previuosly some technically invalid characters were accepted in host names and escaped when they were encountered. This was done for IE6 compat. However, these characters now fail on most users' systems so we can remove the complexity associated with these characters. These invalid characters are now rejected and any URLs with them in the host name are marked invalid. BUG=652808

Patch Set 1 #

Patch Set 2 : Some work #

Patch Set 3 : Merge #

Patch Set 4 : Fix net tests #

Patch Set 5 : Some tests fixed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -104 lines) Patch
M chrome/test/data/extensions/api_test/cookies/api/manifest.json View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/cookies/api/tab.js View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M components/omnibox/browser/autocomplete_input_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M components/omnibox/browser/history_url_provider_unittest.cc View 1 2 chunks +4 lines, -10 lines 0 comments Download
M components/safe_browsing_db/v4_protocol_manager_util.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M components/safe_browsing_db/v4_protocol_manager_util_unittest.cc View 1 2 1 chunk +2 lines, -4 lines 0 comments Download
M components/search_engines/template_url_unittest.cc View 1 2 2 chunks +8 lines, -8 lines 0 comments Download
M content/common/database_identifier_unittest.cc View 1 2 3 4 5 chunks +18 lines, -20 lines 0 comments Download
M net/base/filename_util_unittest.cc View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M net/cert/x509_certificate_unittest.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M net/http/http_security_headers_unittest.cc View 1 2 3 1 chunk +0 lines, -11 lines 0 comments Download
M net/proxy/proxy_config_service_linux_unittest.cc View 1 2 3 1 chunk +0 lines, -15 lines 0 comments Download
M url/url_canon_host.cc View 1 2 3 chunks +7 lines, -21 lines 0 comments Download
M url/url_canon_unittest.cc View 1 2 4 chunks +7 lines, -8 lines 0 comments Download

Messages

Total messages: 17 (12 generated)
brettw
Some work
4 years, 2 months ago (2016-10-10 17:19:59 UTC) #5
brettw
Note to self, still needs: SSLErrorClassificationTest.TestNameMismatch URLBlacklistManagerTest.BlacklistBasicCoverage (hard one)
4 years, 2 months ago (2016-10-10 17:22:45 UTC) #6
brettw
Merge
4 years, 1 month ago (2016-11-11 22:04:52 UTC) #7
brettw
Fix net tests
4 years, 1 month ago (2016-11-14 17:52:56 UTC) #12
brettw
4 years, 1 month ago (2016-11-14 21:45:42 UTC) #17
Some tests fixed

Powered by Google App Engine
This is Rietveld 408576698