Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Unified Diff: net/http/http_security_headers_unittest.cc

Issue 2397873002: Reject some previuosly-escaped chars in hostnames.
Patch Set: Some tests fixed Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/cert/x509_certificate_unittest.cc ('k') | net/proxy/proxy_config_service_linux_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_security_headers_unittest.cc
diff --git a/net/http/http_security_headers_unittest.cc b/net/http/http_security_headers_unittest.cc
index 2d816f1418d6f6a5fe3e8558436c13448216f39b..942c38ed9bd9b03189c4e98cd9632e6afe4c201c 100644
--- a/net/http/http_security_headers_unittest.cc
+++ b/net/http/http_security_headers_unittest.cc
@@ -624,17 +624,6 @@ static void TestValidPKPHeaders(HashValueTag tag) {
EXPECT_EQ(expect_max_age, max_age);
EXPECT_FALSE(include_subdomains);
- // Test that the parser handles escaped values.
- expect_report_uri = GURL("http://foo.com'a");
- EXPECT_TRUE(ParseAsHPKPHeader("max-age=999; " + backup_pin + "; " + good_pin +
- "; report-uri='http://foo.com\\'\\a'",
- chain_hashes, &max_age, &include_subdomains,
- &hashes, &report_uri));
- expect_max_age = base::TimeDelta::FromSeconds(999);
- EXPECT_EQ(expect_max_age, max_age);
- EXPECT_FALSE(include_subdomains);
- EXPECT_EQ(expect_report_uri, report_uri);
-
// Test that the parser does not require max-age for Report-Only
// headers.
expect_report_uri = GURL("http://foo.com");
« no previous file with comments | « net/cert/x509_certificate_unittest.cc ('k') | net/proxy/proxy_config_service_linux_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698