Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(613)

Unified Diff: components/omnibox/browser/history_url_provider_unittest.cc

Issue 2397873002: Reject some previuosly-escaped chars in hostnames.
Patch Set: Some tests fixed Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/omnibox/browser/history_url_provider_unittest.cc
diff --git a/components/omnibox/browser/history_url_provider_unittest.cc b/components/omnibox/browser/history_url_provider_unittest.cc
index 55ee94b7aa72ca66560c58d365e764178fa3ea2b..e714ced16ed3d9c87df86e15211cab78e36a5440 100644
--- a/components/omnibox/browser/history_url_provider_unittest.cc
+++ b/components/omnibox/browser/history_url_provider_unittest.cc
@@ -551,9 +551,9 @@ TEST_F(HistoryURLProviderTestNoSearchProvider, WhatYouTypedNoSearchProvider) {
RunTest(ASCIIToUTF16("wytmatch+foo+bar"), std::string(), false, NULL, 0);
const UrlAndLegalDefault results_2[] = {
- { "http://wytmatch+foo+bar.com/", true }
+ { "http://wytmatch_foo_bar.com/", true }
};
- RunTest(ASCIIToUTF16("wytmatch+foo+bar.com"), std::string(), false,
+ RunTest(ASCIIToUTF16("wytmatch_foo_bar.com"), std::string(), false,
results_2, arraysize(results_2));
}
@@ -571,16 +571,10 @@ TEST_F(HistoryURLProviderTest, WhatYouTyped) {
arraysize(results_1));
const UrlAndLegalDefault results_2[] = {
- { "http://wytmatch%20foo%20bar/", false }
+ { "http://wytmatch/", true }
};
- RunTest(ASCIIToUTF16("http://wytmatch foo bar"), std::string(), false,
+ RunTest(ASCIIToUTF16("http://wytmatch"), std::string(), false,
results_2, arraysize(results_2));
-
- const UrlAndLegalDefault results_3[] = {
- { "https://wytmatch%20foo%20bar/", false }
- };
- RunTest(ASCIIToUTF16("https://wytmatch foo bar"), std::string(), false,
- results_3, arraysize(results_3));
}
TEST_F(HistoryURLProviderTest, Fixup) {
« no previous file with comments | « components/omnibox/browser/autocomplete_input_unittest.cc ('k') | components/safe_browsing_db/v4_protocol_manager_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698