components/omnibox/browser/autocomplete_input_unittest.cc - Issue 2397873002: Reject some previuosly-escaped chars in hostnames.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/omnibox/browser/autocomplete_input_unittest.cc

Issue 2397873002: Reject some previuosly-escaped chars in hostnames.

Patch Set: Some tests fixed Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/omnibox/browser/autocomplete_input_unittest.cc

diff --git a/components/omnibox/browser/autocomplete_input_unittest.cc b/components/omnibox/browser/autocomplete_input_unittest.cc

index 9a632d593e58b7ea01952199a439412bbc6b69c7..b315529ef464ebacd98727e858722fd01f706cbd 100644

--- a/components/omnibox/browser/autocomplete_input_unittest.cc

+++ b/components/omnibox/browser/autocomplete_input_unittest.cc

@@ -50,7 +50,7 @@ TEST(AutocompleteInputTest, InputType) {

{ ASCIIToUTF16("foo bar.com"), metrics::OmniboxInputType::QUERY },

{ ASCIIToUTF16("foo bar"), metrics::OmniboxInputType::QUERY },

{ ASCIIToUTF16("foo+bar"), metrics::OmniboxInputType::QUERY },

- { ASCIIToUTF16("foo+bar.com"), metrics::OmniboxInputType::UNKNOWN },

+ { ASCIIToUTF16("foo+bar.com"), metrics::OmniboxInputType::QUERY },

{ ASCIIToUTF16("\"foo:bar\""), metrics::OmniboxInputType::QUERY },

{ ASCIIToUTF16("link:foo.com"), metrics::OmniboxInputType::UNKNOWN },

{ ASCIIToUTF16("foo:81"), metrics::OmniboxInputType::URL },