components/safe_browsing_db/v4_protocol_manager_util.cc - Issue 2397873002: Reject some previuosly-escaped chars in hostnames.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/safe_browsing_db/v4_protocol_manager_util.cc

Issue 2397873002: Reject some previuosly-escaped chars in hostnames.

Patch Set: Some tests fixed Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/safe_browsing_db/v4_protocol_manager_util.cc

diff --git a/components/safe_browsing_db/v4_protocol_manager_util.cc b/components/safe_browsing_db/v4_protocol_manager_util.cc

index 5d2511551bff93aca15624094772c25f7ff5dcdc..afc46a1b10764af7113017a09cc4acc2fbde26f9 100644

--- a/components/safe_browsing_db/v4_protocol_manager_util.cc

+++ b/components/safe_browsing_db/v4_protocol_manager_util.cc

@@ -348,7 +348,7 @@ void V4ProtocolManagerUtil::CanonicalizeUrl(const GURL& url,

std::string* canonicalized_hostname,

std::string* canonicalized_path,

std::string* canonicalized_query) {

- DCHECK(url.is_valid());

+ DCHECK(url.is_valid()) << url.possibly_invalid_spec();

// We only canonicalize "normal" URLs.

if (!url.IsStandard())