Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 2395553002: Reland "Turn libbase into a component" (Closed)

Created:
4 years, 2 months ago by jochen (gone - plz use gerrit)
Modified:
4 years, 2 months ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland "Turn libbase into a component" Original issue's description: > Turn libbase into a component > > This is a precondition for turning libplatform into a component > > BUG=v8:5412 > R=jgruber@chromium.org,machenbach@chromium.org > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_compile_ dbg_ng;master.tryserver.chromium.android:android_clang_dbg_recipe > > Committed: https://crrev.com/614e615775f732d71b5ee94ed29737d8de687104 > Cr-Commit-Position: refs/heads/master@{#39950} BUG=v8:5412 TBR=jgruber@chromium.org,machenbach@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_compile_dbg_ng;master.tryserver.chromium.android:android_clang_dbg_recipe;master.tryserver.chromium.mac:mac_chromium_compile_dbg_ng Committed: https://crrev.com/17cb51254cafa932025e9980b60f89f756d411cb Cr-Commit-Position: refs/heads/master@{#39969}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+224 lines, -116 lines) Patch
M BUILD.gn View 12 chunks +26 lines, -7 lines 0 comments Download
M samples/samples.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M src/base/atomicops_internals_x86_gcc.h View 2 chunks +4 lines, -1 line 0 comments Download
A src/base/base-export.h View 1 chunk +31 lines, -0 lines 0 comments Download
M src/base/bits.h View 5 chunks +14 lines, -18 lines 0 comments Download
M src/base/cpu.h View 2 chunks +2 lines, -1 line 0 comments Download
M src/base/debug/stack_trace.h View 2 chunks +3 lines, -2 lines 0 comments Download
M src/base/division-by-constant.h View 3 chunks +23 lines, -5 lines 0 comments Download
M src/base/division-by-constant.cc View 2 chunks +0 lines, -10 lines 0 comments Download
M src/base/file-utils.h View 1 chunk +8 lines, -5 lines 0 comments Download
M src/base/file-utils.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M src/base/functional.h View 3 chunks +5 lines, -4 lines 0 comments Download
M src/base/ieee754.h View 1 chunk +22 lines, -20 lines 0 comments Download
M src/base/logging.h View 3 chunks +8 lines, -6 lines 0 comments Download
M src/base/once.h View 2 chunks +3 lines, -1 line 0 comments Download
M src/base/platform/condition-variable.h View 2 chunks +2 lines, -1 line 0 comments Download
M src/base/platform/mutex.h View 3 chunks +3 lines, -2 lines 0 comments Download
M src/base/platform/platform.h View 6 chunks +6 lines, -5 lines 0 comments Download
M src/base/platform/semaphore.h View 2 chunks +2 lines, -1 line 0 comments Download
M src/base/platform/time.h View 7 chunks +11 lines, -5 lines 0 comments Download
M src/base/sys-info.h View 1 chunk +3 lines, -1 line 0 comments Download
M src/base/utils/random-number-generator.h View 2 chunks +2 lines, -1 line 0 comments Download
M src/d8.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M src/heap/spaces.h View 1 chunk +1 line, -1 line 0 comments Download
M src/icu_util.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/startup-data-util.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/v8.gyp View 6 chunks +28 lines, -12 lines 0 comments Download
M test/cctest/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/cctest.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M test/fuzzer/fuzzer.gyp View 2 chunks +2 lines, -0 lines 0 comments Download
M test/unittests/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M test/unittests/unittests.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M tools/parser-shell.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2395553002/1
4 years, 2 months ago (2016-10-05 04:30:38 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-05 04:33:00 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/17cb51254cafa932025e9980b60f89f756d411cb Cr-Commit-Position: refs/heads/master@{#39969}
4 years, 2 months ago (2016-10-05 04:33:17 UTC) #9
Michael Achenbach
lgtm
4 years, 2 months ago (2016-10-05 06:47:25 UTC) #10
adamk
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2396933002/ by adamk@chromium.org. ...
4 years, 2 months ago (2016-10-05 19:14:10 UTC) #11
Michael Achenbach
On 2016/10/05 19:14:10, adamk wrote: > A revert of this CL (patchset #1 id:1) has ...
4 years, 2 months ago (2016-10-05 19:37:44 UTC) #12
Michael Achenbach
4 years, 2 months ago (2016-10-05 19:43:03 UTC) #13
Message was sent while issue was closed.
On 2016/10/05 19:37:44, machenbach (slow) wrote:
> On 2016/10/05 19:14:10, adamk wrote:
> > A revert of this CL (patchset #1 id:1) has been created in
> > https://codereview.chromium.org/2396933002/ by mailto:adamk@chromium.org.
> > 
> > The reason for reverting is: Speculative revert due to very strange-looking
> > win/dbg failures
> > which reference SignedDivisionByConstant:
> > 
> >
>
https://build.chromium.org/p/client.v8/builders/V8%20Win64%20-%20debug/builds....
> 
> Possible that we have an incremental build problem again, due to some unknown
> build deps problems.
> 
> Landing a landmine. Lets see if it gets better. But we might need to get to
the
> bottom of this.
> https://codereview.chromium.org/2392463007

Looking a bit at the problems, they are indeed all happening while this CL was
in. Maybe this misses a deps on windows? It's only happening in debug component
builds.

Powered by Google App Engine
This is Rietveld 408576698