Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Issue 2392463007: [build] Landmine to fix windows build problems (Closed)

Created:
4 years, 2 months ago by Michael Achenbach
Modified:
4 years, 2 months ago
Reviewers:
Michael Hablich
CC:
v8-reviews_googlegroups.com, Michael Achenbach, Leszek Swirski, caitp
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[build] Landmine to fix windows build problems NOTRY=true NOTREECHECKS=true NOPRESUBMIT=true TBR=hablich@chromium.org Committed: https://crrev.com/a16f2ab076482527c3dfdffd7f6509da7391bea0 Cr-Commit-Position: refs/heads/master@{#40010}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M gypfiles/get_landmines.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Michael Achenbach
TBR
4 years, 2 months ago (2016-10-05 19:32:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2392463007/1
4 years, 2 months ago (2016-10-05 19:32:54 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-05 19:33:06 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a16f2ab076482527c3dfdffd7f6509da7391bea0 Cr-Commit-Position: refs/heads/master@{#40010}
4 years, 2 months ago (2016-10-05 19:33:45 UTC) #9
Michael Hablich
4 years, 2 months ago (2016-10-05 20:33:40 UTC) #10
Message was sent while issue was closed.
On 2016/10/05 19:33:45, commit-bot: I haz the power wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/a16f2ab076482527c3dfdffd7f6509da7391bea0
> Cr-Commit-Position: refs/heads/master@{#40010}

lgtm

Powered by Google App Engine
This is Rietveld 408576698