Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 2396933002: Revert of Reland "Turn libbase into a component" (Closed)

Created:
4 years, 2 months ago by adamk
Modified:
4 years, 2 months ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Reland "Turn libbase into a component" (patchset #1 id:1 of https://codereview.chromium.org/2395553002/ ) Reason for revert: Speculative revert due to very strange-looking win/dbg failures which reference SignedDivisionByConstant: https://build.chromium.org/p/client.v8/builders/V8%20Win64%20-%20debug/builds/12736 Original issue's description: > Reland "Turn libbase into a component" > > Original issue's description: > > Turn libbase into a component > > > > This is a precondition for turning libplatform into a component > > > > BUG=v8:5412 > > R=jgruber@chromium.org,machenbach@chromium.org > > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_compile_ > dbg_ng;master.tryserver.chromium.android:android_clang_dbg_recipe > > > > Committed: https://crrev.com/614e615775f732d71b5ee94ed29737d8de687104 > > Cr-Commit-Position: refs/heads/master@{#39950} > > BUG=v8:5412 > TBR=jgruber@chromium.org,machenbach@chromium.org > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_compile_dbg_ng;master.tryserver.chromium.android:android_clang_dbg_recipe;master.tryserver.chromium.mac:mac_chromium_compile_dbg_ng > > Committed: https://crrev.com/17cb51254cafa932025e9980b60f89f756d411cb > Cr-Commit-Position: refs/heads/master@{#39969} TBR=jgruber@chromium.org,machenbach@chromium.org,jochen@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5412 Committed: https://crrev.com/e75b9f6ed5da39e6c7a8d70cf48afbc9958afc85 Cr-Commit-Position: refs/heads/master@{#40009}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -224 lines) Patch
M BUILD.gn View 12 chunks +7 lines, -26 lines 0 comments Download
M samples/samples.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M src/base/atomicops_internals_x86_gcc.h View 2 chunks +1 line, -4 lines 0 comments Download
D src/base/base-export.h View 1 chunk +0 lines, -31 lines 0 comments Download
M src/base/bits.h View 5 chunks +18 lines, -14 lines 0 comments Download
M src/base/cpu.h View 2 chunks +1 line, -2 lines 0 comments Download
M src/base/debug/stack_trace.h View 2 chunks +2 lines, -3 lines 0 comments Download
M src/base/division-by-constant.h View 3 chunks +5 lines, -23 lines 0 comments Download
M src/base/division-by-constant.cc View 2 chunks +10 lines, -0 lines 0 comments Download
M src/base/file-utils.h View 1 chunk +5 lines, -8 lines 0 comments Download
M src/base/file-utils.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M src/base/functional.h View 3 chunks +4 lines, -5 lines 0 comments Download
M src/base/ieee754.h View 1 chunk +20 lines, -22 lines 0 comments Download
M src/base/logging.h View 3 chunks +6 lines, -8 lines 0 comments Download
M src/base/once.h View 2 chunks +1 line, -3 lines 0 comments Download
M src/base/platform/condition-variable.h View 2 chunks +1 line, -2 lines 0 comments Download
M src/base/platform/mutex.h View 3 chunks +2 lines, -3 lines 0 comments Download
M src/base/platform/platform.h View 6 chunks +5 lines, -6 lines 0 comments Download
M src/base/platform/semaphore.h View 2 chunks +1 line, -2 lines 0 comments Download
M src/base/platform/time.h View 7 chunks +5 lines, -11 lines 0 comments Download
M src/base/sys-info.h View 1 chunk +1 line, -3 lines 0 comments Download
M src/base/utils/random-number-generator.h View 2 chunks +1 line, -2 lines 0 comments Download
M src/d8.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M src/heap/spaces.h View 1 chunk +1 line, -1 line 0 comments Download
M src/icu_util.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/startup-data-util.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M src/v8.gyp View 5 chunks +12 lines, -28 lines 0 comments Download
M test/cctest/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/cctest.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M test/fuzzer/fuzzer.gyp View 2 chunks +0 lines, -2 lines 0 comments Download
M test/unittests/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M test/unittests/unittests.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M tools/parser-shell.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
adamk
Created Revert of Reland "Turn libbase into a component"
4 years, 2 months ago (2016-10-05 19:14:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2396933002/1
4 years, 2 months ago (2016-10-05 19:14:17 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-05 19:14:37 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e75b9f6ed5da39e6c7a8d70cf48afbc9958afc85 Cr-Commit-Position: refs/heads/master@{#40009}
4 years, 2 months ago (2016-10-05 19:14:53 UTC) #7
jochen (gone - plz use gerrit)
4 years, 2 months ago (2016-10-07 07:25:11 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2399323002/ by jochen@chromium.org.

The reason for reverting is: let's see whether it sticks this time.

Powered by Google App Engine
This is Rietveld 408576698