Reland "Turn libbase into a component"

Reland "Turn libbase into a component"

Original issue's description:
> Turn libbase into a component
>
> This is a precondition for turning libplatform into a component
>
> BUG=v8:5412
> R=jgruber@chromium.org,machenbach@chromium.org
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_compile_
dbg_ng;master.tryserver.chromium.android:android_clang_dbg_recipe
>
> Committed: https://crrev.com/614e615775f732d71b5ee94ed29737d8de687104
> Cr-Commit-Position: refs/heads/master@{#39950}

BUG=v8:5412
TBR=jgruber@chromium.org,machenbach@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_compile_dbg_ng;master.tryserver.chromium.android:android_clang_dbg_recipe;master.tryserver.chromium.mac:mac_chromium_compile_dbg_ng

Committed: https://crrev.com/17cb51254cafa932025e9980b60f89f756d411cb
Cr-Commit-Position: refs/heads/master@{#39969}

[jochen (gone - plz use gerrit), 2016-10-04 19:03:46]

The CQ bit was checked by jochen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-04 19:04:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-04 19:59:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-04 19:59:23]

Dry run: This issue passed the CQ dry run.

[jochen (gone - plz use gerrit), 2016-10-05 04:30:28]

The CQ bit was checked by jochen@chromium.org

[commit-bot: I haz the power, 2016-10-05 04:30:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-05 04:33:00]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-05 04:33:15]

Description was changed from

==========
Reland "Turn libbase into a component"

Original issue's description:
> Turn libbase into a component
>
> This is a precondition for turning libplatform into a component
>
> BUG=v8:5412
> R=jgruber@chromium.org,machenbach@chromium.org
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_compile_
dbg_ng;master.tryserver.chromium.android:android_clang_dbg_recipe
>
> Committed: https://crrev.com/614e615775f732d71b5ee94ed29737d8de687104
> Cr-Commit-Position: refs/heads/master@{#39950}

BUG=v8:5412
TBR=jgruber@chromium.org,machenbach@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_compile_dbg_ng;master.tryserver.chromium.android:android_clang_dbg_recipe;master.tryserver.chromium.mac:mac_chromium_compile_dbg_ng
==========

to

==========
Reland "Turn libbase into a component"

Original issue's description:
> Turn libbase into a component
>
> This is a precondition for turning libplatform into a component
>
> BUG=v8:5412
> R=jgruber@chromium.org,machenbach@chromium.org
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_compile_
dbg_ng;master.tryserver.chromium.android:android_clang_dbg_recipe
>
> Committed: https://crrev.com/614e615775f732d71b5ee94ed29737d8de687104
> Cr-Commit-Position: refs/heads/master@{#39950}

BUG=v8:5412
TBR=jgruber@chromium.org,machenbach@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_compile_dbg_ng;master.tryserver.chromium.android:android_clang_dbg_recipe;master.tryserver.chromium.mac:mac_chromium_compile_dbg_ng

Committed: https://crrev.com/17cb51254cafa932025e9980b60f89f756d411cb
Cr-Commit-Position: refs/heads/master@{#39969}
==========

[commit-bot: I haz the power, 2016-10-05 04:33:17]

Patchset 1 (id:??) landed as
https://crrev.com/17cb51254cafa932025e9980b60f89f756d411cb
Cr-Commit-Position: refs/heads/master@{#39969}

[Michael Achenbach, 2016-10-05 06:47:25]

lgtm

[adamk, 2016-10-05 19:14:10]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2396933002/ by adamk@chromium.org.

The reason for reverting is: Speculative revert due to very strange-looking
win/dbg failures
which reference SignedDivisionByConstant:

https://build.chromium.org/p/client.v8/builders/V8%20Win64%20-%20debug/builds....

[Michael Achenbach, 2016-10-05 19:37:44]

On 2016/10/05 19:14:10, adamk wrote:
> A revert of this CL (patchset #1 id:1) has been created in
> https://codereview.chromium.org/2396933002/ by mailto:adamk@chromium.org.
> 
> The reason for reverting is: Speculative revert due to very strange-looking
> win/dbg failures
> which reference SignedDivisionByConstant:
> 
>
https://build.chromium.org/p/client.v8/builders/V8%20Win64%20-%20debug/builds....

Possible that we have an incremental build problem again, due to some unknown
build deps problems.

Landing a landmine. Lets see if it gets better. But we might need to get to the
bottom of this.
https://codereview.chromium.org/2392463007

[Michael Achenbach, 2016-10-05 19:43:03]

On 2016/10/05 19:37:44, machenbach (slow) wrote:
> On 2016/10/05 19:14:10, adamk wrote:
> > A revert of this CL (patchset #1 id:1) has been created in
> > https://codereview.chromium.org/2396933002/ by mailto:adamk@chromium.org.
> > 
> > The reason for reverting is: Speculative revert due to very strange-looking
> > win/dbg failures
> > which reference SignedDivisionByConstant:
> > 
> >
>
https://build.chromium.org/p/client.v8/builders/V8%20Win64%20-%20debug/builds....
> 
> Possible that we have an incremental build problem again, due to some unknown
> build deps problems.
> 
> Landing a landmine. Lets see if it gets better. But we might need to get to
the
> bottom of this.
> https://codereview.chromium.org/2392463007

Looking a bit at the problems, they are indeed all happening while this CL was
in. Maybe this misses a deps on windows? It's only happening in debug component
builds.