Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 2391823002: [DevTools] Introduce Target.setAutoAttach. (Closed)

Created:
4 years, 2 months ago by dgozman
Modified:
4 years, 2 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, jam, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, darin-cc_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Introduce Target.setAutoAttach. This separates passive "listen to all targets" behavior from "auto-attach to related targets" required by DevTools frontend. BUG=648775 Committed: https://crrev.com/bf5f253616dfb7f6bb1f3e490b2a0804561dea5d Cr-Commit-Position: refs/heads/master@{#422674}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+133 lines, -61 lines) Patch
M content/browser/devtools/protocol/target_handler.h View 3 chunks +4 lines, -1 line 0 comments Download
M content/browser/devtools/protocol/target_handler.cc View 8 chunks +35 lines, -10 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/profiler/agents-disabled-check-expected.txt View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/browser_protocol.json View 4 chunks +21 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/ServiceWorkerManager.js View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/SubTargetsManager.js View 11 chunks +68 lines, -39 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 12 (7 generated)
dgozman
Could you please take a look?
4 years, 2 months ago (2016-10-03 22:58:16 UTC) #2
pfeldman
lgtm
4 years, 2 months ago (2016-10-03 23:06:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2391823002/1
4 years, 2 months ago (2016-10-04 02:19:11 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-04 02:24:57 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 02:26:49 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bf5f253616dfb7f6bb1f3e490b2a0804561dea5d
Cr-Commit-Position: refs/heads/master@{#422674}

Powered by Google App Engine
This is Rietveld 408576698