Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Issue 2383743003: [DevTools] Auto-attach to cross-process subframes under experiment. (Closed)

Created:
4 years, 2 months ago by dgozman
Modified:
4 years, 2 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, jam, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, darin-cc_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Auto-attach to cross-process subframes under experiment. Fixed immediate UI problems by introducing TargetNameChanged event. This is enough for the targets scope, modulo attach/detach tests. UI polish would be addressed later under a separate bug. BUG=648775 Committed: https://crrev.com/478ac0e1bbcd86ebddb50816261f93392fa881f4 Cr-Commit-Position: refs/heads/master@{#422553}

Patch Set 1 #

Patch Set 2 : some ui #

Unified diffs Side-by-side diffs Delta from patch set Stats (+178 lines, -24 lines) Patch
M content/browser/devtools/protocol/target_handler.h View 1 3 chunks +9 lines, -1 line 0 comments Download
M content/browser/devtools/protocol/target_handler.cc View 1 6 chunks +57 lines, -6 lines 0 comments Download
M content/browser/devtools/render_frame_devtools_agent_host.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/browser_protocol.json View 1 2 chunks +8 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/main/Main.js View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/profiler/TargetsComboBoxController.js View 1 2 chunks +11 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/SubTargetsManager.js View 1 4 chunks +11 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/Target.js View 1 2 chunks +7 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js View 1 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js View 1 4 chunks +31 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/ThreadsSidebarPane.js View 1 4 chunks +39 lines, -10 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 19 (14 generated)
dgozman
Could you please take a look?
4 years, 2 months ago (2016-10-01 00:49:00 UTC) #4
pfeldman
lgtm
4 years, 2 months ago (2016-10-03 21:55:58 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2383743003/20001
4 years, 2 months ago (2016-10-03 21:58:07 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-03 22:06:02 UTC) #17
commit-bot: I haz the power
4 years, 2 months ago (2016-10-03 22:08:55 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/478ac0e1bbcd86ebddb50816261f93392fa881f4
Cr-Commit-Position: refs/heads/master@{#422553}

Powered by Google App Engine
This is Rietveld 408576698