Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Unified Diff: third_party/WebKit/Source/core/inspector/browser_protocol.json

Issue 2391823002: [DevTools] Introduce Target.setAutoAttach. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/browser_protocol.json
diff --git a/third_party/WebKit/Source/core/inspector/browser_protocol.json b/third_party/WebKit/Source/core/inspector/browser_protocol.json
index f5b55c98b63b044f61f6bf34ee1686d6d3e2a944..a2cf152e8b375e6550f106d5773545c68894de73 100644
--- a/third_party/WebKit/Source/core/inspector/browser_protocol.json
+++ b/third_party/WebKit/Source/core/inspector/browser_protocol.json
@@ -3264,7 +3264,7 @@
},
{
"domain": "Target",
- "description": "Supports discovery and auto-attach to related targets.",
+ "description": "Supports additional targets discovery and allows to attach to them.",
"experimental": true,
"types": [
{
@@ -3290,7 +3290,7 @@
"commands": [
{
"name": "enable",
- "description": "Start discovering targets and attach to all related targets from now on.",
+ "description": "Start discovering targets.",
"handlers": ["browser"]
},
{
@@ -3299,9 +3299,11 @@
"handlers": ["browser"]
},
{
- "name": "setWaitForDebuggerOnStart",
+ "name": "setAutoAttach",
+ "description": "Controls whether to automatically attach to new targets which are considered to be related to this one. When turned on, attaches to all existing related targets as well. When turned off, does not automatically detach.",
"parameters": [
- { "name": "value", "type": "boolean", "description": "Whether to pause new targets when attaching to them. Use <code>Runtime.runIfWaitingForDebugger</code> to run puased targets." }
+ { "name": "autoAttach", "type": "boolean", "description": "Whether to auto-attach to related targets." },
+ { "name": "waitForDebuggerOnStart", "type": "boolean", "description": "Whether to pause new targets when attaching to them. Use <code>Runtime.runIfWaitingForDebugger</code> to run paused targets." }
],
"handlers": ["browser"]
},
@@ -3342,15 +3344,27 @@
{
"name": "targetCreated",
"parameters": [
+ { "name": "targetInfo", "$ref": "TargetInfo" }
+ ],
+ "handlers": ["browser"]
+ },
+ {
+ "name": "targetRemoved",
+ "parameters": [
+ { "name": "targetId", "$ref": "TargetID" }
+ ],
+ "handlers": ["browser"]
+ },
+ {
+ "name": "attachedToTarget",
+ "parameters": [
{ "name": "targetId", "$ref": "TargetID" },
- { "name": "type", "$ref": "TargetType" },
- { "name": "url", "type": "string" },
{ "name": "waitingForDebugger", "type": "boolean" }
],
"handlers": ["browser"]
},
{
- "name": "targetRemoved",
+ "name": "detachedFromTarget",
"parameters": [
{ "name": "targetId", "$ref": "TargetID" }
],

Powered by Google App Engine
This is Rietveld 408576698