Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 2387283003: [DevTools] Support all targets discovery in Target domain. (Closed)

Created:
4 years, 2 months ago by dgozman
Modified:
4 years, 2 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, jam, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, darin-cc_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Support all targets discovery in Target domain. This is protocol-only change, no implementation yet. BUG=648775 Committed: https://crrev.com/4b53ab6afaf075529678e8ce6ea082dd03935a8d Cr-Commit-Position: refs/heads/master@{#423334}

Patch Set 1 #

Patch Set 2 : small fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -42 lines) Patch
M content/browser/devtools/protocol/target_handler.h View 3 chunks +5 lines, -4 lines 0 comments Download
M content/browser/devtools/protocol/target_handler.cc View 1 10 chunks +40 lines, -29 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/browser_protocol.json View 2 chunks +23 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/SubTargetsManager.js View 1 chunk +0 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 14 (9 generated)
dgozman
Take a look please.
4 years, 2 months ago (2016-10-05 19:00:51 UTC) #4
pfeldman
lgtm
4 years, 2 months ago (2016-10-05 23:16:28 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2387283003/20001
4 years, 2 months ago (2016-10-05 23:17:41 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-05 23:24:54 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-10-05 23:27:32 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4b53ab6afaf075529678e8ce6ea082dd03935a8d
Cr-Commit-Position: refs/heads/master@{#423334}

Powered by Google App Engine
This is Rietveld 408576698