third_party/WebKit/Source/devtools/front_end/sdk/ServiceWorkerManager.js - Issue 2391823002: [DevTools] Introduce Target.setAutoAttach.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/sdk/ServiceWorkerManager.js

Issue 2391823002: [DevTools] Introduce Target.setAutoAttach. (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/inspector/browser_protocol.json ('k') | third_party/WebKit/Source/devtools/front_end/sdk/SubTargetsManager.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/sdk/ServiceWorkerManager.js

diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/ServiceWorkerManager.js b/third_party/WebKit/Source/devtools/front_end/sdk/ServiceWorkerManager.js

index ea199de7bc05e6d81b0ea41ace3697b6733745a6..517769612422a2dc2296287f2cc3d12b9d5d02b1 100644

--- a/third_party/WebKit/Source/devtools/front_end/sdk/ServiceWorkerManager.js

+++ b/third_party/WebKit/Source/devtools/front_end/sdk/ServiceWorkerManager.js

@@ -611,9 +611,10 @@ WebInspector.ServiceWorkerContextNamer.prototype = {

var parent = target.parentTarget();

if (!parent || parent.parentTarget() !== this._target)

return null;

- if (this._subTargetsManager.targetType(parent) !== "service_worker")

+ var targetInfo = this._subTargetsManager.targetInfo(parent);

+ if (!targetInfo || targetInfo.type !== "service_worker")

return null;

- return this._subTargetsManager.targetId(parent);

+ return targetInfo.id;

_updateAllContextLabels: function()