Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 2390563002: Reflow comments in core/html/forms/. (Closed)

Created:
4 years, 2 months ago by tkent
Modified:
4 years, 2 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reflow comments in core/html/forms/. This CL has no behavior changes. BUG=563793 Committed: https://crrev.com/35c6377052771b615c563e1306141d1082c25e71 Cr-Commit-Position: refs/heads/master@{#422372}

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -67 lines) Patch
M third_party/WebKit/Source/core/html/forms/BaseCheckableInputType.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/forms/CheckboxInputType.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/forms/DateTimeLocalInputType.cpp View 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/forms/FileInputType.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/forms/FileInputType.cpp View 3 chunks +9 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/html/forms/FormController.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/forms/FormController.cpp View 2 chunks +6 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/html/forms/ImageInputType.h View 1 chunk +3 lines, -2 lines 2 comments Download
M third_party/WebKit/Source/core/html/forms/ImageInputType.cpp View 2 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/forms/InputType.h View 3 chunks +12 lines, -8 lines 2 comments Download
M third_party/WebKit/Source/core/html/forms/InputType.cpp View 4 chunks +12 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/html/forms/InputTypeView.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/forms/KeyboardClickableInputTypeView.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/forms/MultipleFieldsTemporalInputTypeView.cpp View 2 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/forms/RadioButtonGroupScope.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/forms/RadioInputType.cpp View 5 chunks +15 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/html/forms/StepRange.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/forms/StepRangeTest.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/forms/TextFieldInputType.cpp View 2 chunks +5 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/forms/TypeAhead.cpp View 2 chunks +10 lines, -7 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
tkent
yosin@, would you stamp this please?
4 years, 2 months ago (2016-10-03 03:47:06 UTC) #5
yosin_UTC9
lgtm w/ suggestions https://codereview.chromium.org/2390563002/diff/1/third_party/WebKit/Source/core/html/forms/ImageInputType.h File third_party/WebKit/Source/core/html/forms/ImageInputType.h (right): https://codereview.chromium.org/2390563002/diff/1/third_party/WebKit/Source/core/html/forms/ImageInputType.h#newcode76 third_party/WebKit/Source/core/html/forms/ImageInputType.h:76: // Valid only during HTMLFormElement::prepareForSubmission(). I ...
4 years, 2 months ago (2016-10-03 04:00:24 UTC) #6
tkent
https://codereview.chromium.org/2390563002/diff/1/third_party/WebKit/Source/core/html/forms/ImageInputType.h File third_party/WebKit/Source/core/html/forms/ImageInputType.h (right): https://codereview.chromium.org/2390563002/diff/1/third_party/WebKit/Source/core/html/forms/ImageInputType.h#newcode76 third_party/WebKit/Source/core/html/forms/ImageInputType.h:76: // Valid only during HTMLFormElement::prepareForSubmission(). On 2016/10/03 at 04:00:24, ...
4 years, 2 months ago (2016-10-03 04:14:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2390563002/1
4 years, 2 months ago (2016-10-03 04:45:56 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-03 04:51:26 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-10-03 04:53:31 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/35c6377052771b615c563e1306141d1082c25e71
Cr-Commit-Position: refs/heads/master@{#422372}

Powered by Google App Engine
This is Rietveld 408576698