Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(631)

Unified Diff: third_party/WebKit/Source/core/html/forms/InputType.h

Issue 2390563002: Reflow comments in core/html/forms/. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/forms/InputType.h
diff --git a/third_party/WebKit/Source/core/html/forms/InputType.h b/third_party/WebKit/Source/core/html/forms/InputType.h
index 8cd73b276edd8fb94454bc5a316cdd95f771be13..bad4b6d87fe3ba999346a02dcdb7387c614322b3 100644
--- a/third_party/WebKit/Source/core/html/forms/InputType.h
+++ b/third_party/WebKit/Source/core/html/forms/InputType.h
@@ -87,12 +87,14 @@ class CORE_EXPORT InputType : public GarbageCollectedFinalized<InputType> {
// DOM property functions
- virtual bool getTypeSpecificValue(
- String&); // Checked first, before internal storage or the value attribute.
- virtual String fallbackValue()
- const; // Checked last, if both internal storage and value attribute are missing.
- virtual String defaultValue()
- const; // Checked after even fallbackValue, only when the valueWithDefault function is called.
+ // Checked first, before internal storage or the value attribute.
yosin_UTC9 2016/10/03 04:00:24 It seems function comment and function declaration
tkent 2016/10/03 04:14:14 IMO, it's out of scope of this CL, and should be a
+ virtual bool getTypeSpecificValue(String&);
+ // Checked last, if both internal storage and value attribute are missing.
+ virtual String fallbackValue() const;
+ // Checked after even fallbackValue, only when the valueWithDefault function
+ // is called.
+ virtual String defaultValue() const;
+
virtual double valueAsDate() const;
virtual void setValueAsDate(double, ExceptionState&) const;
virtual double valueAsDouble() const;
@@ -169,7 +171,8 @@ class CORE_EXPORT InputType : public GarbageCollectedFinalized<InputType> {
// Should return true if the given DragData has more than one dropped files.
virtual bool receiveDroppedFiles(const DragData*);
virtual String droppedFileSystemId();
- // Should return true if the corresponding layoutObject for a type can display a suggested value.
+ // Should return true if the corresponding layoutObject for a type can display
+ // a suggested value.
virtual bool canSetSuggestedValue();
virtual bool shouldSendChangeEventAfterCheckedChanged();
virtual bool canSetValue(const String&);
@@ -242,7 +245,8 @@ class CORE_EXPORT InputType : public GarbageCollectedFinalized<InputType> {
const String& value) const;
private:
- // Helper for stepUp()/stepDown(). Adds step value * count to the current value.
+ // Helper for stepUp()/stepDown(). Adds step value * count to the current
+ // value.
void applyStep(const Decimal&,
int count,
AnyStepHandling,

Powered by Google App Engine
This is Rietveld 408576698