Issue 239023002: Revert of Rename wm_core_export.h to wm_export.h and the wm_core target to just wm

Issue 239023002: Revert of Rename wm_core_export.h to wm_export.h and the wm_core target to just wm (Closed)

Created:
6 years, 8 months ago by ppi

Modified:
6 years, 8 months ago

Reviewers:
sky, Ben Goodger (Google)

CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, sadrul, tfarina, jam, darin-cc_chromium.org, oshima+watch_chromium.org, kalyank, stevenjb+watch_chromium.org, ben+ash_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Revert of Rename wm_core_export.h to wm_export.h and the wm_core target to just wm (https://codereview.chromium.org/237873003/) Reason for revert: Seems to have broken compile on the Linux builders: http://build.chromium.org/p/chromium.linux/builders/Linux%20Builder/builds/29879 ninja:error: unknown target 'wm_core_unittests' Original issue's description: > Rename wm_core_export.h to wm_export.h and the wm_core target to just wm > > Extracted from https://codereview.chromium.org/209383003/ > > http://crbug.com/308710 > TBR=sky@chromium.org > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263812 TBR=sky@chromium.org,ben@chromium.org NOTREECHECKS=true NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263815

Patch Set 1 #

Created: 6 years, 8 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+156 lines, -141 lines)			Patch
M	ash/ash.gyp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/chrome_browser_ui.gypi	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/chrome_tests_unit.gypi	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/content_shell.gypi	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/app_list/app_list.gyp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/chromeos/ui_chromeos.gyp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/keyboard/keyboard.gyp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/views/views.gyp	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	ui/wm/core/base_focus_rules.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/wm/core/capture_controller.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	ui/wm/core/compound_event_filter.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	ui/wm/core/cursor_manager.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	ui/wm/core/easy_resize_window_targeter.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	ui/wm/core/focus_controller.h	View	2 chunks	+5 lines, -5 lines	0 comments	Download
M	ui/wm/core/focus_rules.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	ui/wm/core/image_grid.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	ui/wm/core/input_method_event_filter.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	ui/wm/core/masked_window_targeter.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	ui/wm/core/native_cursor_manager.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	ui/wm/core/native_cursor_manager_delegate.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	ui/wm/core/shadow.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	ui/wm/core/shadow_controller.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	ui/wm/core/shadow_types.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	ui/wm/core/transient_window_controller.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	ui/wm/core/transient_window_manager.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	ui/wm/core/transient_window_observer.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	ui/wm/core/transient_window_stacking_client.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	ui/wm/core/user_activity_detector.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	ui/wm/core/user_activity_observer.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	ui/wm/core/visibility_controller.h	View	3 chunks	+4 lines, -4 lines	0 comments	Download
M	ui/wm/core/window_animations.h	View	4 chunks	+15 lines, -13 lines	0 comments	Download
M	ui/wm/core/window_animations.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/wm/core/window_modality_controller.h	View	2 chunks	+6 lines, -6 lines	0 comments	Download
M	ui/wm/core/window_util.h	View	3 chunks	+17 lines, -15 lines	0 comments	Download
A	ui/wm/core/wm_core_export.h	View	1 chunk	+32 lines, -0 lines	0 comments	Download
M	ui/wm/core/wm_core_switches.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	ui/wm/core/wm_state.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	ui/wm/wm.gyp	View	5 chunks	+17 lines, -6 lines	0 comments	Download
D	ui/wm/wm_export.h	View	1 chunk	+0 lines, -32 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ppi

Created Revert of Rename wm_core_export.h to wm_export.h and the wm_core target to just wm

6 years, 8 months ago (2014-04-15 12:15:51 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ppi@chromium.org/239023002/1

6 years, 8 months ago (2014-04-15 12:16:21 UTC) #2

Message was sent while issue was closed.

Change committed as 263815

Expand Messages | Collapse Messages