Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Issue 2389493002: Revert of Require WebLocalFrame to be created with a non-null client (Closed)

Created:
4 years, 2 months ago by dcheng
Modified:
4 years, 2 months ago
Reviewers:
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Require WebLocalFrame to be created with a non-null client (patchset #5 id:80001 of https://codereview.chromium.org/2369613003/ ) Reason for revert: Also just testing. Original issue's description: > Require WebLocalFrame to be created with a non-null client > > This simplifies the invariants around WebLocalFrames in Blink: > the client is only ever null once the frame is detached. In > theory, this should allow the removal of a bunch of random > WebFrameClient null checks. > > BUG=none > > Committed: https://crrev.com/9f8e2f611e44753f7d8de5a2a6716bd030bc7283 > Cr-Commit-Position: refs/heads/master@{#421832} TBR=jochen@chromium.org,dglazkov@chromium.org,esprehn@chromium.org,liberato@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=none

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+177 lines, -124 lines) Patch
M components/plugins/renderer/webview_plugin.h View 1 chunk +5 lines, -0 lines 0 comments Download
M components/plugins/renderer/webview_plugin.cc View 2 chunks +6 lines, -3 lines 0 comments Download
M components/printing/renderer/print_web_view_helper.cc View 4 chunks +18 lines, -7 lines 0 comments Download
M content/renderer/media/android/media_info_loader_unittest.cc View 3 chunks +8 lines, -5 lines 0 comments Download
M content/renderer/render_frame_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M content/test/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A content/test/mock_webframeclient.h View 1 chunk +16 lines, -0 lines 0 comments Download
M extensions/renderer/scoped_web_frame.h View 2 chunks +6 lines, -10 lines 0 comments Download
M extensions/renderer/scoped_web_frame.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M media/blink/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A media/blink/mock_webframeclient.h View 1 chunk +16 lines, -0 lines 0 comments Download
M media/blink/multibuffer_data_source_unittest.cc View 3 chunks +9 lines, -7 lines 0 comments Download
M media/blink/resource_multibuffer_data_provider_unittest.cc View 5 chunks +9 lines, -7 lines 0 comments Download
M media/blink/webmediaplayer_impl_unittest.cc View 3 chunks +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/EmptyClients.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/FrameLoader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/FrameLoaderClient.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/ChromeClientImpl.cpp View 2 chunks +10 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/web/FrameLoaderClientImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
D third_party/WebKit/Source/web/WebFrameClient.cpp View 1 chunk +0 lines, -23 lines 0 comments Download
M third_party/WebKit/Source/web/WebLocalFrameImpl.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/ChromeClientImplTest.cpp View 4 chunks +6 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/tests/FrameLoaderClientImplTest.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/FrameTestHelpers.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/FrameTestHelpers.cpp View 1 chunk +14 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/tests/WebFrameTest.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/web/tests/WebViewTest.cpp View 5 chunks +7 lines, -6 lines 0 comments Download
M third_party/WebKit/public/web/WebFrameClient.h View 5 chunks +18 lines, -18 lines 0 comments Download
M third_party/WebKit/public/web/WebLocalFrame.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (6 generated)
dcheng
4 years, 2 months ago (2016-10-01 02:10:11 UTC) #1
Created Revert of Require WebLocalFrame to be created with a non-null client

Powered by Google App Engine
This is Rietveld 408576698