third_party/WebKit/public/web/WebLocalFrame.h - Issue 2389493002: Revert of Require WebLocalFrame to be created with a non-null client

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/public/web/WebLocalFrame.h

Issue 2389493002: Revert of Require WebLocalFrame to be created with a non-null client (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/public/web/WebLocalFrame.h

diff --git a/third_party/WebKit/public/web/WebLocalFrame.h b/third_party/WebKit/public/web/WebLocalFrame.h

index 39814cc78b782b3453dc88cff46f047ca273f28f..dc4815df7ac7cc9a4db735fe1dfab17958392b25 100644

--- a/third_party/WebKit/public/web/WebLocalFrame.h

+++ b/third_party/WebKit/public/web/WebLocalFrame.h

@@ -37,7 +37,7 @@

class WebLocalFrame : public WebFrame {

public:

// Creates a WebFrame. Delete this WebFrame by calling WebFrame::close().

- // WebFrameClient may not be null.

+ // It is valid to pass a null client pointer.

BLINK_EXPORT static WebLocalFrame* create(WebTreeScopeType, WebFrameClient*, WebFrame* opener = nullptr);

// Used to create a provisional local frame in prepration for replacing a

« no previous file with comments | « third_party/WebKit/public/web/WebFrameClient.h ('k') | no next file » | no next file with comments »