Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(592)

Unified Diff: content/renderer/render_frame_impl.cc

Issue 2389493002: Revert of Require WebLocalFrame to be created with a non-null client (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/render_frame_impl.h ('k') | content/test/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_frame_impl.cc
diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc
index 829f6226658c7eee94113739f08051d4ff799fe9..59744b0aeab929bfaacf17af84890c70b2d58437 100644
--- a/content/renderer/render_frame_impl.cc
+++ b/content/renderer/render_frame_impl.cc
@@ -2818,7 +2818,7 @@
has_accessed_initial_document_ = true;
}
-blink::WebLocalFrame* RenderFrameImpl::createChildFrame(
+blink::WebFrame* RenderFrameImpl::createChildFrame(
blink::WebLocalFrame* parent,
blink::WebTreeScopeType scope,
const blink::WebString& name,
@@ -2942,10 +2942,9 @@
Send(new FrameHostMsg_FrameFocused(routing_id_));
}
-void RenderFrameImpl::willCommitProvisionalLoad(blink::WebLocalFrame* frame) {
+void RenderFrameImpl::willClose(blink::WebFrame* frame) {
DCHECK_EQ(frame_, frame);
- // TODO(dcheng): Rename observer to FrameWillCommitProvisionalLoad.
FOR_EACH_OBSERVER(RenderFrameObserver, observers_, FrameWillClose());
FOR_EACH_OBSERVER(RenderViewObserver, render_view_->observers(),
FrameWillClose(frame));
« no previous file with comments | « content/renderer/render_frame_impl.h ('k') | content/test/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698