third_party/WebKit/Source/web/tests/FrameLoaderClientImplTest.cpp - Issue 2389493002: Revert of Require WebLocalFrame to be created with a non-null client

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/tests/FrameLoaderClientImplTest.cpp

Issue 2389493002: Revert of Require WebLocalFrame to be created with a non-null client (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/tests/FrameLoaderClientImplTest.cpp

diff --git a/third_party/WebKit/Source/web/tests/FrameLoaderClientImplTest.cpp b/third_party/WebKit/Source/web/tests/FrameLoaderClientImplTest.cpp

index 9d4c750b589a6121c4d535088ba5100e40d588be..3127ab781ea2e75a6a89f3a398f3c3feb68964f6 100644

--- a/third_party/WebKit/Source/web/tests/FrameLoaderClientImplTest.cpp

+++ b/third_party/WebKit/Source/web/tests/FrameLoaderClientImplTest.cpp

@@ -74,6 +74,7 @@

void TearDown() override

{

m_webView->close();

+ m_mainFrame->close();

}

WebString userAgent()

@@ -91,7 +92,7 @@

private:

MockWebFrameClient m_webFrameClient;

WebView* m_webView;

- WebLocalFrame* m_mainFrame;

+ WebFrame* m_mainFrame;

};

TEST_F(FrameLoaderClientImplTest, UserAgentOverride)