third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp - Issue 2389493002: Revert of Require WebLocalFrame to be created with a non-null client

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp

Issue 2389493002: Revert of Require WebLocalFrame to be created with a non-null client (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp

diff --git a/third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp b/third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp

index 3d4abe9aa49f85fafdd94633bd84ea83ebe1c888..a0684f80b7e06f7374b48af6c614da0578e5e1e5 100644

--- a/third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp

+++ b/third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp

@@ -435,10 +435,10 @@

m_webFrame->client()->didNavigateWithinPage(m_webFrame, WebHistoryItem(item), static_cast<WebHistoryCommitType>(commitType), contentInitiated);

}

-void FrameLoaderClientImpl::dispatchWillCommitProvisionalLoad()

- if (m_webFrame->client())

- m_webFrame->client()->willCommitProvisionalLoad(m_webFrame);

+void FrameLoaderClientImpl::dispatchWillClose()

+ if (m_webFrame->client())

+ m_webFrame->client()->willClose(m_webFrame);

}

void FrameLoaderClientImpl::dispatchDidStartProvisionalLoad(double triggeringEventTime)