Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Unified Diff: components/sync/device_info/local_device_info_provider_unittest.cc

Issue 2388973002: [Sync] Removing duplicate includes, part 2. (Closed)
Patch Set: Update for Max's comments. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/sync/device_info/local_device_info_provider_unittest.cc
diff --git a/components/sync/device_info/local_device_info_provider_unittest.cc b/components/sync/device_info/local_device_info_provider_unittest.cc
deleted file mode 100644
index cc2c2c36e77ecf5c51f5c0d6bddbda0089179f3c..0000000000000000000000000000000000000000
--- a/components/sync/device_info/local_device_info_provider_unittest.cc
+++ /dev/null
@@ -1,143 +0,0 @@
-// Copyright 2014 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "base/bind.h"
-#include "base/message_loop/message_loop.h"
-#include "base/run_loop.h"
-#include "components/sync/base/get_session_name.h"
-#include "components/sync/device_info/local_device_info_provider_impl.h"
-#include "components/version_info/version_info.h"
-#include "testing/gtest/include/gtest/gtest.h"
-
-namespace syncer {
-
-const char kLocalDeviceGuid[] = "foo";
-const char kSigninScopedDeviceId[] = "device_id";
-
-class LocalDeviceInfoProviderTest : public testing::Test {
- public:
- LocalDeviceInfoProviderTest() : called_back_(false) {}
- ~LocalDeviceInfoProviderTest() override {}
-
- void SetUp() override {
- provider_.reset(new LocalDeviceInfoProviderImpl(
- version_info::Channel::UNKNOWN,
- version_info::GetVersionStringWithModifier("UNKNOWN"), false));
- }
-
- void TearDown() override {
- provider_.reset();
- called_back_ = false;
- }
-
- protected:
- void StartInitializeProvider() { StartInitializeProvider(kLocalDeviceGuid); }
-
- void StartInitializeProvider(const std::string& guid) {
- provider_->Initialize(guid, kSigninScopedDeviceId,
- message_loop_.task_runner());
- }
-
- void FinishInitializeProvider() {
- // Subscribe to the notification and wait until the callback
- // is called. The callback will quit the loop.
- base::RunLoop run_loop;
- std::unique_ptr<LocalDeviceInfoProvider::Subscription> subscription =
- provider_->RegisterOnInitializedCallback(
- base::Bind(&LocalDeviceInfoProviderTest::QuitLoopOnInitialized,
- base::Unretained(this), &run_loop));
- run_loop.Run();
- }
-
- void InitializeProvider() {
- StartInitializeProvider();
- FinishInitializeProvider();
- }
-
- void QuitLoopOnInitialized(base::RunLoop* loop) {
- called_back_ = true;
- loop->Quit();
- }
-
- std::unique_ptr<LocalDeviceInfoProviderImpl> provider_;
-
- bool called_back_;
-
- private:
- base::MessageLoop message_loop_;
-};
-
-TEST_F(LocalDeviceInfoProviderTest, OnInitializedCallback) {
- ASSERT_FALSE(called_back_);
- StartInitializeProvider();
- ASSERT_FALSE(called_back_);
- FinishInitializeProvider();
- EXPECT_TRUE(called_back_);
-}
-
-TEST_F(LocalDeviceInfoProviderTest, GetLocalDeviceInfo) {
- ASSERT_EQ(nullptr, provider_->GetLocalDeviceInfo());
- StartInitializeProvider();
- ASSERT_EQ(nullptr, provider_->GetLocalDeviceInfo());
- FinishInitializeProvider();
-
- const DeviceInfo* local_device_info = provider_->GetLocalDeviceInfo();
- ASSERT_NE(nullptr, local_device_info);
- EXPECT_EQ(std::string(kLocalDeviceGuid), local_device_info->guid());
- EXPECT_EQ(std::string(kSigninScopedDeviceId),
- local_device_info->signin_scoped_device_id());
- EXPECT_EQ(GetSessionNameSynchronouslyForTesting(),
- local_device_info->client_name());
-
- EXPECT_EQ(provider_->GetSyncUserAgent(),
- local_device_info->sync_user_agent());
-
- provider_->Clear();
- ASSERT_EQ(nullptr, provider_->GetLocalDeviceInfo());
-}
-
-TEST_F(LocalDeviceInfoProviderTest, GetLocalSyncCacheGUID) {
- EXPECT_TRUE(provider_->GetLocalSyncCacheGUID().empty());
-
- StartInitializeProvider();
- EXPECT_EQ(std::string(kLocalDeviceGuid), provider_->GetLocalSyncCacheGUID());
-
- FinishInitializeProvider();
- EXPECT_EQ(std::string(kLocalDeviceGuid), provider_->GetLocalSyncCacheGUID());
-
- provider_->Clear();
- EXPECT_TRUE(provider_->GetLocalSyncCacheGUID().empty());
-}
-
-TEST_F(LocalDeviceInfoProviderTest, InitClearRace) {
- EXPECT_TRUE(provider_->GetLocalSyncCacheGUID().empty());
- StartInitializeProvider();
-
- provider_->Clear();
- ASSERT_EQ(nullptr, provider_->GetLocalDeviceInfo());
- EXPECT_TRUE(provider_->GetLocalSyncCacheGUID().empty());
-
- base::RunLoop().RunUntilIdle();
- ASSERT_EQ(nullptr, provider_->GetLocalDeviceInfo());
- EXPECT_TRUE(provider_->GetLocalSyncCacheGUID().empty());
-}
-
-TEST_F(LocalDeviceInfoProviderTest, InitClearInitRace) {
- EXPECT_TRUE(provider_->GetLocalSyncCacheGUID().empty());
- StartInitializeProvider();
- provider_->Clear();
-
- const std::string guid2 = "guid2";
- StartInitializeProvider(guid2);
- ASSERT_EQ(nullptr, provider_->GetLocalDeviceInfo());
- EXPECT_EQ(guid2, provider_->GetLocalSyncCacheGUID());
-
- FinishInitializeProvider();
- const DeviceInfo* local_device_info = provider_->GetLocalDeviceInfo();
- ASSERT_NE(nullptr, local_device_info);
- EXPECT_EQ(guid2, local_device_info->guid());
- EXPECT_EQ(guid2, provider_->GetLocalSyncCacheGUID());
-}
-
-} // namespace syncer

Powered by Google App Engine
This is Rietveld 408576698