components/sync_sessions/revisit/typed_url_page_revisit_task_unittest.cc - Issue 2388973002: [Sync] Removing duplicate includes, part 2.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/sync_sessions/revisit/typed_url_page_revisit_task_unittest.cc

Issue 2388973002: [Sync] Removing duplicate includes, part 2. (Closed)

Patch Set: Update for Max's comments. Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « components/sync_sessions/revisit/sessions_page_revisit_observer_unittest.cc ('k') | components/sync_sessions/synced_session_tracker_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "components/sync_sessions/revisit/typed_url_page_revisit_task.h"	5 #include "components/sync_sessions/revisit/typed_url_page_revisit_task.h"

6	6

7 #include "base/test/histogram_tester.h"	7 #include "base/test/histogram_tester.h"

8 #include "base/time/time.h"	8 #include "base/time/time.h"

9 #include "components/history/core/browser/history_backend.h"	9 #include "components/history/core/browser/history_backend.h"

10 #include "components/history/core/browser/history_types.h"

11 #include "components/sync_sessions/revisit/page_visit_observer.h"

12 #include "testing/gtest/include/gtest/gtest.h"	10 #include "testing/gtest/include/gtest/gtest.h"

13 #include "url/gurl.h"

14	11

15 namespace sync_sessions {	12 namespace sync_sessions {

16	13

17 namespace {	14 namespace {

18	15

19 class FakeTask : public TypedUrlPageRevisitTask {	16 class FakeTask : public TypedUrlPageRevisitTask {

20 public:	17 public:

21 FakeTask(const PageVisitObserver::TransitionType transition,	18 FakeTask(const PageVisitObserver::TransitionType transition,

22 bool result,	19 bool result,

23 const history::VisitVector& visits,	20 const history::VisitVector& visits,

(...skipping 117 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
141 // No source for id 3.	138 // No source for id 3.

142	139

143 FakeTask task(PageVisitObserver::TransitionType::kTransitionPage, true,	140 FakeTask task(PageVisitObserver::TransitionType::kTransitionPage, true,

144 visits, sources);	141 visits, sources);

145 base::Time lastVisitTime;	142 base::Time lastVisitTime;

146 ASSERT_TRUE(task.FindLastSyncedMatchAge(nullptr, &lastVisitTime));	143 ASSERT_TRUE(task.FindLastSyncedMatchAge(nullptr, &lastVisitTime));

147 ASSERT_EQ(expected, lastVisitTime);	144 ASSERT_EQ(expected, lastVisitTime);

148 }	145 }

149	146

150 } // namespace sync_sessions	147 } // namespace sync_sessions

OLD	NEW