components/sync_sessions/revisit/page_revisit_broadcaster_unittest.cc - Issue 2388973002: [Sync] Removing duplicate includes, part 2.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/sync_sessions/revisit/page_revisit_broadcaster_unittest.cc

Issue 2388973002: [Sync] Removing duplicate includes, part 2. (Closed)

Patch Set: Update for Max's comments. Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « components/sync_sessions/revisit/offset_tab_matcher_unittest.cc ('k') | components/sync_sessions/revisit/sessions_page_revisit_observer_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "components/sync_sessions/revisit/page_revisit_broadcaster.h"	5 #include "components/sync_sessions/revisit/page_revisit_broadcaster.h"

6	6

7 #include <stdint.h>	7 #include <stdint.h>

8	8

9 #include "components/sync_sessions/revisit/page_visit_observer.h"

10 #include "testing/gtest/include/gtest/gtest.h"	9 #include "testing/gtest/include/gtest/gtest.h"

11 #include "ui/base/page_transition_types.h"

12	10

13 namespace sync_sessions {	11 namespace sync_sessions {

14	12

15 class SyncPageRevisitBroadcasterTest : public ::testing::Test {	13 class SyncPageRevisitBroadcasterTest : public ::testing::Test {

16 protected:	14 protected:

17 PageVisitObserver::TransitionType Convert(	15 PageVisitObserver::TransitionType Convert(

18 const ui::PageTransition conversionInput) {	16 const ui::PageTransition conversionInput) {

19 return PageRevisitBroadcaster::ConvertTransitionEnum(conversionInput);	17 return PageRevisitBroadcaster::ConvertTransitionEnum(conversionInput);

20 }	18 }

21	19

(...skipping 79 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
101 TEST_F(SyncPageRevisitBroadcasterTest, ConvertUnknown) {	99 TEST_F(SyncPageRevisitBroadcasterTest, ConvertUnknown) {

102 Check(PageVisitObserver::kTransitionUnknown,	100 Check(PageVisitObserver::kTransitionUnknown,

103 ui::PAGE_TRANSITION_AUTO_SUBFRAME);	101 ui::PAGE_TRANSITION_AUTO_SUBFRAME);

104 Check(PageVisitObserver::kTransitionUnknown,	102 Check(PageVisitObserver::kTransitionUnknown,

105 ui::PAGE_TRANSITION_MANUAL_SUBFRAME);	103 ui::PAGE_TRANSITION_MANUAL_SUBFRAME);

106 Check(PageVisitObserver::kTransitionUnknown,	104 Check(PageVisitObserver::kTransitionUnknown,

107 ui::PAGE_TRANSITION_AUTO_TOPLEVEL);	105 ui::PAGE_TRANSITION_AUTO_TOPLEVEL);

108 }	106 }

109	107

110 } // namespace sync_sessions	108 } // namespace sync_sessions

OLD	NEW