components/sync_sessions/lost_navigations_recorder_unittest.cc - Issue 2388973002: [Sync] Removing duplicate includes, part 2.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/sync_sessions/lost_navigations_recorder_unittest.cc

Issue 2388973002: [Sync] Removing duplicate includes, part 2. (Closed)

Patch Set: Update for Max's comments. Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « components/sync_sessions/lost_navigations_recorder.cc ('k') | components/sync_sessions/revisit/bookmarks_page_revisit_observer_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

	5 #include "components/sync_sessions/lost_navigations_recorder.h"

	6

5 #include <memory>	7 #include <memory>

6	8

7 #include "base/message_loop/message_loop.h"	9 #include "base/message_loop/message_loop.h"

8 #include "base/test/histogram_tester.h"	10 #include "base/test/histogram_tester.h"

9 #include "components/sessions/core/session_id.h"

10 #include "components/sync/core/attachments/attachment_service_proxy_for_test.h"	11 #include "components/sync/core/attachments/attachment_service_proxy_for_test.h"

11 #include "components/sync/syncable/entry.h"	12 #include "components/sync/syncable/entry.h"

12 #include "components/sync/syncable/mutable_entry.h"	13 #include "components/sync/syncable/mutable_entry.h"

13 #include "components/sync/syncable/syncable_base_transaction.h"	14 #include "components/sync/syncable/syncable_base_transaction.h"

14 #include "components/sync/syncable/syncable_read_transaction.h"	15 #include "components/sync/syncable/syncable_read_transaction.h"

15 #include "components/sync/syncable/syncable_write_transaction.h"	16 #include "components/sync/syncable/syncable_write_transaction.h"

16 #include "components/sync/test/engine/test_directory_setter_upper.h"	17 #include "components/sync/test/engine/test_directory_setter_upper.h"

17 #include "components/sync/test/engine/test_id_factory.h"	18 #include "components/sync/test/engine/test_id_factory.h"

18 #include "components/sync_sessions/lost_navigations_recorder.h"	19 #include "components/sync_sessions/lost_navigations_recorder.h"

19 #include "components/sync_sessions/sessions_sync_manager.h"	20 #include "components/sync_sessions/sessions_sync_manager.h"

(...skipping 369 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
389 ->DeleteSubrange(0, 2);	390 ->DeleteSubrange(0, 2);

390 RecordChange(&mutable_entry, specifics);	391 RecordChange(&mutable_entry, specifics);

391	392

392 TriggerReconcile(&mutable_entry, true, &specifics);	393 TriggerReconcile(&mutable_entry, true, &specifics);

393	394

394 histogram_tester.ExpectBucketCount("Sync.LostNavigationCount", 2, 1);	395 histogram_tester.ExpectBucketCount("Sync.LostNavigationCount", 2, 1);

395 }	396 }

396	397

397 }; // namespace	398 }; // namespace

398 }; // namespace sync_sessions	399 }; // namespace sync_sessions

OLD	NEW