Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Issue 2386013002: Hoist target element null-checks out of SVGAnimateElement::calculate* (Closed)

Created:
4 years, 2 months ago by fs
Modified:
4 years, 2 months ago
Reviewers:
pdr., Stephen Chennney
CC:
fs, darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, krit, Eric Willigers, f(malita), gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rjwright, rwlbuis, Stephen Chennney, shans
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Hoist target element null-checks out of SVGAnimateElement::calculate* The calculateFromAndToValues, calculateFromAndByValues and calculateDistance share a common entrypoint (startedActiveInterval), so we can tighten this code-path a bit checking for a target element up front. (No target element makes for pretty useless animations anyway...) calculateAnimatedValue gets similar treatment in its updateAnimation (sole) entrypoint. Also refill comments to 80 columns in SVGAnimateMotionElement.cpp. BUG=641437 Committed: https://crrev.com/19f7c54a725c49bbc2bc683d1069c2217f302cb9 Cr-Commit-Position: refs/heads/master@{#422484}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -22 lines) Patch
M third_party/WebKit/Source/core/svg/SVGAnimateElement.cpp View 6 chunks +9 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGAnimateMotionElement.cpp View 3 chunks +7 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGAnimationElement.cpp View 2 chunks +3 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (8 generated)
fs
4 years, 2 months ago (2016-10-01 18:08:38 UTC) #6
Stephen Chennney
lgtm
4 years, 2 months ago (2016-10-03 16:05:43 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2386013002/1
4 years, 2 months ago (2016-10-03 17:53:34 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-03 19:16:02 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-10-03 19:18:01 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/19f7c54a725c49bbc2bc683d1069c2217f302cb9
Cr-Commit-Position: refs/heads/master@{#422484}

Powered by Google App Engine
This is Rietveld 408576698