Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 2384013002: Push animation value 'inherit' handling into SVGAnimateElement (Closed)

Created:
4 years, 2 months ago by fs
Modified:
4 years, 2 months ago
Reviewers:
pdr., Stephen Chennney
CC:
fs, darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, krit, Eric Willigers, f(malita), gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rjwright, rwlbuis, Stephen Chennney, shans
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Push animation value 'inherit' handling into SVGAnimateElement Handling of 'inherit' doesn't need to live on SVGAnimationElement, because only SVGAnimateElement makes use of it. Move it down the class structure and simplify. Also refill/wrap comments in the files touched to 80 columns. BUG=641437 Committed: https://crrev.com/7d339bf79eea750800d0957fc3acbe0f4c0da679 Cr-Commit-Position: refs/heads/master@{#422446}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -143 lines) Patch
M third_party/WebKit/Source/core/svg/SVGAnimateElement.h View 2 chunks +10 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGAnimateElement.cpp View 11 chunks +74 lines, -40 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGAnimationElement.h View 6 chunks +0 lines, -35 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGAnimationElement.cpp View 8 chunks +13 lines, -68 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (8 generated)
fs
4 years, 2 months ago (2016-10-01 18:08:09 UTC) #6
Stephen Chennney
lgtm
4 years, 2 months ago (2016-10-03 16:03:13 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2384013002/1
4 years, 2 months ago (2016-10-03 16:18:09 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-03 17:21:09 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-10-03 17:24:21 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7d339bf79eea750800d0957fc3acbe0f4c0da679
Cr-Commit-Position: refs/heads/master@{#422446}

Powered by Google App Engine
This is Rietveld 408576698