Hoist target element null-checks out of SVGAnimateElement::calculate*

third_party/WebKit/Source/core/svg/SVGAnimateMotionElement.cpp

 /*
  * Copyright (C) 2007 Eric Seidel <eric@webkit.org>
  * Copyright (C) 2007 Rob Buis <buis@kde.org>
  * Copyright (C) 2008 Apple Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
@@ skipping 33 matching lines @@
 
 DEFINE_NODE_FACTORY(SVGAnimateMotionElement)
 
 SVGAnimateMotionElement::~SVGAnimateMotionElement() {}
 
 bool SVGAnimateMotionElement::hasValidAttributeType() {
   SVGElement* targetElement = this->targetElement();
   if (!targetElement)
     return false;
 
-  // We don't have a special attribute name to verify the animation type. Check the element name instead.
+  // We don't have a special attribute name to verify the animation type. Check
+  // the element name instead.
   if (!targetElement->isSVGGraphicsElement())
     return false;
   // Spec: SVG 1.1 section 19.2.15
-  // FIXME: svgTag is missing. Needs to be checked, if transforming <svg> could cause problems.
+  // FIXME: svgTag is missing. Needs to be checked, if transforming <svg> could
+  // cause problems.
   return (
       isSVGGElement(*targetElement) || isSVGDefsElement(*targetElement) ||
       isSVGUseElement(*targetElement) || isSVGImageElement(*targetElement) ||
       isSVGSwitchElement(*targetElement) || isSVGPathElement(*targetElement) ||
       isSVGRectElement(*targetElement) || isSVGCircleElement(*targetElement) ||
       isSVGEllipseElement(*targetElement) || isSVGLineElement(*targetElement) ||
       isSVGPolylineElement(*targetElement) ||
       isSVGPolygonElement(*targetElement) || isSVGTextElement(*targetElement) ||
       isSVGClipPathElement(*targetElement) ||
       isSVGMaskElement(*targetElement) || isSVGAElement(*targetElement) ||
@@ skipping 131 matching lines @@
   parsePoint(byString, byPoint);
   m_toPoint =
       FloatPoint(m_fromPoint.x() + byPoint.x(), m_fromPoint.y() + byPoint.y());
   return true;
 }
 
 void SVGAnimateMotionElement::calculateAnimatedValue(float percentage,
                                                      unsigned repeatCount,
                                                      SVGSMILElement*) {
   SVGElement* targetElement = this->targetElement();
-  if (!targetElement)
-    return;
+  DCHECK(targetElement);
   AffineTransform* transform = targetElement->animateMotionTransform();
   if (!transform)
     return;
 
   if (LayoutObject* targetLayoutObject = targetElement->layoutObject())
     targetLayoutObject->setNeedsTransformUpdate();
 
   if (!isAdditive())
     transform->makeIdentity();
 
@@ skipping 32 matching lines @@
   transform->translate(position.x(), position.y());
   RotateMode rotateMode = this->getRotateMode();
   if (rotateMode != RotateAuto && rotateMode != RotateAutoReverse)
     return;
   if (rotateMode == RotateAutoReverse)
     angle += 180;
   transform->rotate(angle);
 }
 
 void SVGAnimateMotionElement::applyResultsToTarget() {
-  // We accumulate to the target element transform list so there is not much to do here.
+  // We accumulate to the target element transform list so there is not much to
+  // do here.
   SVGElement* targetElement = this->targetElement();
   if (!targetElement)
     return;
 
   if (LayoutObject* layoutObject = targetElement->layoutObject())
     markForLayoutAndParentResourceInvalidation(layoutObject);
 
   AffineTransform* t = targetElement->animateMotionTransform();
   if (!t)
     return;
@@ skipping 27 matching lines @@
 }
 
 void SVGAnimateMotionElement::updateAnimationMode() {
   if (!m_animationPath.isEmpty())
     setAnimationMode(PathAnimation);
   else
     SVGAnimationElement::updateAnimationMode();
 }
 
 }  // namespace blink