Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Issue 2383403002: Reflow comments in core/loader (Closed)

Created:
4 years, 2 months ago by Charlie Harrison
Modified:
4 years, 2 months ago
Reviewers:
yhirano
CC:
chromium-reviews, michaeln, tyoshino+watch_chromium.org, nessy, gavinp+prerender_chromium.org, gasubic, Yoav Weiss, eric.carlson_apple.com, fs, loading-reviews_chromium.org, gavinp+loader_chromium.org, blink-reviews, Nate Chapin, vcarbune.chromium
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reflow comments in core/loader BUG=563793 Committed: https://crrev.com/4013d22a7d6569f5761b437d88b9cf716909f223 Cr-Commit-Position: refs/heads/master@{#422419}

Patch Set 1 #

Total comments: 6

Patch Set 2 : yhirano comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+683 lines, -567 lines) Patch
M third_party/WebKit/Source/core/loader/CrossOriginPreflightResultCache.h View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/loader/CrossOriginPreflightResultCache.cpp View 1 chunk +5 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/loader/DocumentLoadTiming.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/DocumentLoader.cpp View 14 chunks +35 lines, -31 lines 0 comments Download
M third_party/WebKit/Source/core/loader/DocumentThreadableLoader.h View 1 5 chunks +28 lines, -31 lines 0 comments Download
M third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp View 29 chunks +96 lines, -83 lines 0 comments Download
M third_party/WebKit/Source/core/loader/EmptyClients.h View 1 chunk +9 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/loader/FormSubmission.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/FrameFetchContext.cpp View 15 chunks +51 lines, -44 lines 0 comments Download
M third_party/WebKit/Source/core/loader/FrameFetchContextTest.cpp View 7 chunks +18 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/core/loader/FrameLoadRequest.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/loader/FrameLoader.h View 7 chunks +27 lines, -24 lines 0 comments Download
M third_party/WebKit/Source/core/loader/FrameLoader.cpp View 40 chunks +124 lines, -101 lines 0 comments Download
M third_party/WebKit/Source/core/loader/FrameLoaderClient.h View 9 chunks +29 lines, -28 lines 0 comments Download
M third_party/WebKit/Source/core/loader/FrameLoaderStateMachine.h View 3 chunks +8 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/loader/FrameLoaderStateMachine.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/HistoryItem.cpp View 2 chunks +5 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/loader/HttpEquiv.h View 1 1 chunk +6 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/loader/HttpEquiv.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/ImageLoader.h View 3 chunks +18 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/core/loader/ImageLoader.cpp View 1 16 chunks +55 lines, -40 lines 0 comments Download
M third_party/WebKit/Source/core/loader/LinkLoader.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/LinkLoader.cpp View 3 chunks +10 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/loader/LinkLoaderTest.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/loader/MixedContentChecker.cpp View 13 chunks +46 lines, -44 lines 0 comments Download
M third_party/WebKit/Source/core/loader/NavigationScheduler.h View 2 chunks +5 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/loader/NavigationScheduler.cpp View 5 chunks +21 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/core/loader/PingLoader.h View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/loader/PingLoader.cpp View 6 chunks +13 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/loader/PrerenderHandle.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/loader/ProgressTracker.cpp View 1 chunk +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/loader/TextResourceDecoderBuilder.cpp View 2 chunks +10 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/loader/TextTrackLoader.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/ThreadableLoader.h View 3 chunks +11 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/loader/appcache/ApplicationCacheHost.cpp View 5 chunks +16 lines, -14 lines 0 comments Download

Messages

Total messages: 18 (10 generated)
Charlie Harrison
yhirano, ptal? Thanks!
4 years, 2 months ago (2016-10-03 02:12:10 UTC) #6
yhirano
lgtm All suggestions are optional. https://codereview.chromium.org/2383403002/diff/1/third_party/WebKit/Source/core/loader/DocumentThreadableLoader.h File third_party/WebKit/Source/core/loader/DocumentThreadableLoader.h (right): https://codereview.chromium.org/2383403002/diff/1/third_party/WebKit/Source/core/loader/DocumentThreadableLoader.h#newcode237 third_party/WebKit/Source/core/loader/DocumentThreadableLoader.h:237: HTTPHeaderMap m_simpleRequestHeaders; // stores ...
4 years, 2 months ago (2016-10-03 08:37:34 UTC) #7
Charlie Harrison
https://codereview.chromium.org/2383403002/diff/1/third_party/WebKit/Source/core/loader/DocumentThreadableLoader.h File third_party/WebKit/Source/core/loader/DocumentThreadableLoader.h (right): https://codereview.chromium.org/2383403002/diff/1/third_party/WebKit/Source/core/loader/DocumentThreadableLoader.h#newcode237 third_party/WebKit/Source/core/loader/DocumentThreadableLoader.h:237: HTTPHeaderMap m_simpleRequestHeaders; // stores simple request headers in On ...
4 years, 2 months ago (2016-10-03 12:30:06 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2383403002/20001
4 years, 2 months ago (2016-10-03 12:30:22 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/41041)
4 years, 2 months ago (2016-10-03 14:26:05 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2383403002/20001
4 years, 2 months ago (2016-10-03 14:27:47 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-03 14:54:13 UTC) #16
commit-bot: I haz the power
4 years, 2 months ago (2016-10-03 14:55:42 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4013d22a7d6569f5761b437d88b9cf716909f223
Cr-Commit-Position: refs/heads/master@{#422419}

Powered by Google App Engine
This is Rietveld 408576698